GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update article.md by JesusZS · Pull Request #385 · javascript-tutorial/es.javascript.info

Conversation

@JesusZS

@JesusZS JesusZS commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Traducción casi finalizada, faltan pulir detalles en lo referente al uso de términos y la gramática, estoy atento a consejos.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JesusZS
Update article.md
99a9d12
Traducción casi finalizada, faltan pulir detalles en lo referente al uso de términos y la gramática, estoy atento a consejos.
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 21, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 21, 2020 22:11
@CLAassistant

CLAassistant commented Sep 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio
joaquinelio reviewed Sep 22, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola!
Lo primero que noto son los números de línea, necesitamos que respeten exactamente el original,
facilita la review y ESPECIALMENTE permiten un buen diff con el master ingles para las actualizaciones,
gracias

No miré la traducción, y para glosario me gustaría la colaboración de

                  @cortizg 

que anduvo con esto de los patrones y que es buen reviewesero =)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
vplentinax
vplentinax requested changes Oct 7, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por tu colaboración @MrC0D . Quisiera recomendarte mucha precaución con el tema de las líneas por varias razones ya mencionadas por @joaquinelio :

  1. Dificulta la sincronización del repositorio
  2. Dificulta la revisión

A parte de esto, también te sugiero prestar atención a las faltas otrográficas:

  • Espacios tras puntos.
  • Mayúsculas tras puntos
  • Acentos

Hacer bien esto nos permitirá a los reviwers hacer unas revisiones más rápidas y así avanzar más rápido.

Gracias!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Oct 7, 2020
@javascript-translate-bot

javascript-translate-bot commented Oct 7, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Oct 7, 2020
@joaquinelio

joaquinelio commented Dec 4, 2020

Copy link
Copy Markdown
Member

Hello @vplentinax

1 que hacemos con este pr? "draft"
nros de linea, ortografia, faltan las tareas
pero no seria dificil arreglarlo, ya pusiste varios acentos Y las tareas las puedo poner como issue

2 qué tanto te molesta "mirar adelante /atrás" ?
"mirar hacia adelante" me suena innecesariamente largo, hasta redundante,
pero rae dice que es tema regional,
si te es apenas raro, prefiero como está
si en cambio te suena a error, lo ponemos a tu española manera (¿y qué dicen los colombianos?).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio joaquinelio mentioned this pull request Dec 4, 2020
Spanish Translation Progress #17
Open
joaquinelio and others added 4 commits February 16, 2021 15:39
@joaquinelio @vplentinax
Update 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md
cf7aad4
Co-authored-by: Valentiina VP <[email protected]>
@joaquinelio @vplentinax
Update 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md
618da2d
Co-authored-by: Valentiina VP <[email protected]>
@joaquinelio @vplentinax
Update 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md
31b6fb8
Co-authored-by: Valentiina VP <[email protected]>
@joaquinelio @vplentinax
Update 9-regular-expressions/14-regexp-lookahead-lookbehind/article.md
10718dd
Co-authored-by: Valentiina VP <[email protected]>
@joaquinelio

joaquinelio commented Feb 16, 2021

Copy link
Copy Markdown
Member

@vplentinax
el branch esta vivo aunque el autor no
la tomo para no desperdiciar trad y tus correcciones, y le agrego la task

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio @vplentinax
Apply suggestions from code review
0f6635c
Co-authored-by: Valentiina VP <[email protected]>
@vplentinax

vplentinax commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

@vplentinax
el branch esta vivo aunque el autor no
la tomo para no desperdiciar trad y tus correcciones, y le agrego la task

Si puedes hacerte cargo estaría bien...
Por cierto, espero que el autor también esté vivo!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
Merge branch 'master' into patch-1
247e7e5
@joaquinelio

joaquinelio commented Feb 16, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Ugh.
no quise matarlo...
tengo que "cuidar mi lenguaje"

hiciste montones de correcciones, las acepte todas,
resolvi 2 conflictos....
en un art de poco más de 100 lineas jajaj, los coment son mas largos
todo por respetar los 2 autores

tengo problems con lookahead lookbehind. No es una palabra, es una contraccion para manejarse mejor
en ruso le puso "anticipatorio retrospectiva
"mirar hacia delante" me suena feo, largo y redundante pero bue, DRAE dice que es regional y lo acepte

pero es impractico
mira esto

También podemos unirlos en un solo lookbehind aquí:

"en un solo mirar hacia delante aqui: " ??

y hay frases con varios lookahead /behind
quiza invente
verdelante
no se que poner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 2 commits February 18, 2021 15:44
@joaquinelio
enajenado
f322171
@joaquinelio
Merge branch 'master' into patch-1
c1080c5
@joaquinelio

joaquinelio commented Feb 18, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@vplentinax
antes de que corrijas explico motivos de los mas polemicos

  • linea 3 preceder y anteceder son sinonimos ( es "precede / sucede" pero "sucede" confundiria)

  • en unix usabamos "look-ahead" incluso en traducciones, cortito y practico. Lo hubiera dejado ingles.
    Como no es un comando ni palabra clave prefiero "ver delante" asi entre comillas (porque significa: "revisar lo que tenés delante")
    Lo veo importante para no embarrar frases con varios "mirar hacia delante", es imposible no distraerse.
    Ah, "ver delante" es correcto en España y latam, (www.fundeu.es/recomendacion/adelante/) aunque "coloquiemos" distinto.
    Pero
    en MDN aparece como sugeriste "mirar hacia delante", no suelo hacerle caso porque su Esp suele ser incoherente... aunque no acá.
    Más que gramática me encantaria tener opinion de @cortizg u otro experimentado acá, pero si no, aceptaría tu veto.

  • 36 esta mal, la reescribi
    y la reescribí bastante distinto en PR ingles (seguro Ilya rechaza pero deberia corregirlo de algun modo)

  • Debería haber corregido el codigo y vuelto los string de nuevo al ingles, no lo hice. Pereza.

  • si aceptas "ver delante" sigo con los ejercicios en otro PR, tienen muchos "lookahead"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
joaquinelio marked this pull request as ready for review February 18, 2021 19:04
@joaquinelio
joaquinelio requested a review from vplentinax February 18, 2021 19:13
joaquinelio added 2 commits March 2, 2021 04:36
@joaquinelio
Merge branch 'master' into patch-1
5dc67c9
@joaquinelio
Update article.md
fd04542
@joaquinelio

joaquinelio commented Mar 2, 2021

Copy link
Copy Markdown
Member

No puedo respetar a MDN. En una explicación ponen

"mirar hacia delante"
"mirar hacia atras"

pero depues
"aserción de búsqueda anticipada "
"aserción de búsqueda inversa "

que no tienen sentido,
ademas "anticipo" es para tiempo, no posición.

correcto:
de subsecuencia
de precedencia

comodo:
derecha
izquierda
o
posterior
anterior

pero sigo con "ver delante - ver detras" salvo que lo vetes, te sigo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaquinelio added 2 commits March 2, 2021 07:32
@joaquinelio
Update article.md
7abc64a
@joaquinelio
looks
cc56b85
@joaquinelio
Update article.md
62aca34
@joaquinelio

joaquinelio commented Jun 18, 2021

Copy link
Copy Markdown
Member

art cortisimo, pero mucho trbjo de 3 personas
MERGE

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaquinelio
joaquinelio merged commit 8f5eab0 into javascript-tutorial:master Jun 18, 2021
joaquinelio added a commit that referenced this pull request Jun 18, 2021
@joaquinelio
Merge pull request #490 from joaquinelio/taka
fb7cbac
9-14 lookaround tareas -atado otro pr -resolver #385 primero- x temas de glosario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio left review comments
@vplentinax vplentinax Awaiting requested review from vplentinax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JesusZS @CLAassistant @javascript-translate-bot @joaquinelio @vplentinax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.