GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Garbage collection by mahdiHash · Pull Request #123 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented May 16, 2021

Copy link

Copy Markdown

Contributor

Please review and comment / commit if anything is wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 10 commits

May 13, 2021 12:56


          Translate a part of "article.md"

a0bda58


          Translate a part of "article.md"

d4b5544


          Translate a part of "article.md"

2e5b799


          Translate a part of "article.md"

46f5429


          Translate a part of "article.md"

c9b51b1


          Translate a part of "article.md"

9853f04


          Change a hyperlink to Persian version


          Translate a part of "article.md"

b70dd02


          Translate a part of "article.md"

dd02a70


          Translate "article.md"

a3bc91f

Please review and comment / commit if anything is wrong.

javascript-translate-bot added the review needed label

May 16, 2021

javascript-translate-bot requested a review from a team

May 16, 2021 14:41

javascript-translate-bot mentioned this pull request

May 16, 2021

Persian (Farsi) Translation Progress #1

Open

mahdyar requested changes

May 16, 2021

View reviewed changes

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/04-object-basics/03-garbage-collection/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

May 16, 2021

javascript-translate-bot commented May 16, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash and others added 2 commits

May 16, 2021 21:12


          Apply suggestions from code review

4459f0e

Co-authored-by: Mahdyar Hasanpour <[email protected]>


          Apply suggested change

f7478c3

mahdiHash commented May 16, 2021

Copy link

Copy Markdown

Contributor Author

Thanks for your review, @mahdyar
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

May 16, 2021

javascript-translate-bot requested a review from a team

May 16, 2021 16:45

mahdyar approved these changes

May 16, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

May 16, 2021

mahdyar merged commit ab4b86c into javascript-tutorial:master

May 16, 2021

javascript-translate-bot commented May 16, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdyar added a commit that referenced this pull request

May 16, 2021


          Merge pull request #124 from mahdiHashemi14/master

6ec8008

Fix "Garbage collection" (#123)

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.