GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — F.prototype by flaviohblima · Pull Request #231 · javascript-tutorial/pt.javascript.info

Conversation

flaviohblima commented Oct 25, 2021

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          FEAT: Translate F.prototype article, task and solution to pt.

2f6340c

javascript-translate-bot added the review needed label

Oct 25, 2021

javascript-translate-bot requested a review from a team

October 25, 2021 02:55

javascript-translate-bot mentioned this pull request

Oct 25, 2021

Portuguese Translation Progress #1

Open

odsantos requested changes

Oct 26, 2021

View reviewed changes

odsantos left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flaviohblima ,

Here is a review.

Two files in the "1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor" folder seem not yet translated.

Please, feel free to comment where you might disagree.

Thank you,
Osvaldo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/08-prototypes/02-function-prototype/1-changing-prototype/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/1-changing-prototype/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/1-changing-prototype/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Oct 26, 2021

javascript-translate-bot commented Oct 26, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Oct 26, 2021


          FIX: article/tasks reviews resolved. Translate missing task.

6ed9576

flaviohblima commented Oct 28, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Oct 28, 2021

javascript-translate-bot requested a review from a team

October 28, 2021 16:41


          FIX: Resolving reviews.

75ce566

flaviohblima commented Oct 29, 2021

Copy link

Copy Markdown

Contributor Author

Hello @odsantos ,

I missed some of your reviews in my last reading. Sorry.

Now I think I resolved everything.

I did not resolve this one, because I do not use the "de" like this.

If its ok for you, I believe now its done.

Thank you for your reviews!
Flávio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

odsantos commented Oct 29, 2021

Copy link

Copy Markdown

Contributor

Hello @flaviohblima ,
Thank you for your message.

I hope to check it as soon as possible. Probably, within a few days.

However, I still see my review notes. I believe I shouldn't if they were resolved and committed.
But it might be all right, as well.

Osvaldo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

odsantos requested changes

Oct 31, 2021

View reviewed changes

odsantos left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flaviohblima ,

Here is another review.

Thank you,
Osvaldo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Oct 31, 2021

javascript-translate-bot commented Oct 31, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Oct 31, 2021

flaviohblima and others added 5 commits

November 1, 2021 13:40


          Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…

74f456d

…structor/solution.md

Co-authored-by: Osvaldo Dias dos Santos <[email protected]>


          Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…

fa0c64e

…structor/solution.md

Co-authored-by: Osvaldo Dias dos Santos <[email protected]>


          Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…

4d86e7c

…structor/solution.md

Co-authored-by: Osvaldo Dias dos Santos <[email protected]>


          Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…

525cc2e

…structor/solution.md

Co-authored-by: Osvaldo Dias dos Santos <[email protected]>


          Update 1-js/08-prototypes/02-function-prototype/article.md

2157dd4

Co-authored-by: Osvaldo Dias dos Santos <[email protected]>

flaviohblima commented Nov 1, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Nov 1, 2021

javascript-translate-bot requested a review from a team

November 1, 2021 16:44

odsantos requested changes

Nov 19, 2021

View reviewed changes

odsantos left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flaviohblima ,

I reopened a conversation and I still am insisting on that one with 'de'.
Would you mind if I ask you to review it again?
Please, I continue open to your appreciation of my review.

Thank you,
Osvaldo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Nov 19, 2021

javascript-translate-bot commented Nov 19, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Nov 19, 2021


          Update 1-js/08-prototypes/02-function-prototype/article.md

Co-authored-by: Osvaldo Dias dos Santos <[email protected]>

flaviohblima commented Nov 24, 2021

Copy link

Copy Markdown

Contributor Author

Hello @odsantos ,

If you insist, I see no problem fixing it. I already commited the change.

Thank you,
Flávio

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

flaviohblima commented Nov 24, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Nov 24, 2021

javascript-translate-bot requested a review from a team

November 24, 2021 14:37

odsantos approved these changes

Nov 28, 2021

View reviewed changes

odsantos left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @flaviohblima ,

I appreciate the patience you had.
By the rules, we need a second reviewer for your work to be merged.

Let's hope that either @luizclr, @Mr-Saxobeat, @adriavieira314, or @kiniggit have time for that.

Best regards,
Osvaldo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Nov 28, 2021

CLAassistant commented Apr 29, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls requested changes

Jul 6, 2022

View reviewed changes

jonnathan-ls left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaviohblima

I recorded some notes

Note: the images (SVG) have not been translated.

I didn't add the above note in the review, but I was wondering if you could perform the script translation procedure? As per image translation guidance at https://github.com/javascript-tutorial/server#translating-images

If not, no problem, I perform the procedure separately in another Pull Request.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/1-changing-prototype/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/08-prototypes/02-function-prototype/1-changing-prototype/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Jul 6, 2022

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jul 6, 2022

jonnathan-ls added 2 commits

September 17, 2023 22:22


          refactor: applies the corrections requested in the second review of t…

e159873

…he PR#231

Pull Request: #231


          refactor: translates pending texts in svg files

2e32549

jonnathan-ls commented Sep 18, 2023

Copy link

Copy Markdown

Contributor

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls commented Sep 18, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

jonnathan-ls requested changes on behalf of https://github.com/orgs/javascript-tutorial/teams/translate-pt on Jul 6, 2022

I applied the corrections I requested by contributing to the PR to be able to accept the request

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls approved these changes

Sep 18, 2023

View reviewed changes

javascript-translate-bot removed the changes requested label

Sep 18, 2023

jonnathan-ls merged commit b569358 into javascript-tutorial:master

Sep 18, 2023

javascript-translate-bot commented Sep 18, 2023

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

jonnathan-ls reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls removed the needs +1 label

Sep 18, 2023

Reviewers

odsantos

odsantos approved these changes

jonnathan-ls

jonnathan-ls approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

flaviohblima commented Oct 25, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 26, 2021

Uh oh!

flaviohblima commented Oct 28, 2021

Uh oh!

flaviohblima commented Oct 29, 2021

Uh oh!

odsantos commented Oct 29, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 31, 2021

Uh oh!

flaviohblima commented Nov 1, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commented Nov 19, 2021

Uh oh!

flaviohblima commented Nov 24, 2021

Uh oh!

flaviohblima commented Nov 24, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonnathan-ls left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 6, 2022

Uh oh!

jonnathan-ls commented Sep 18, 2023

Uh oh!

jonnathan-ls commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 18, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

CLAassistant commented Apr 29, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls commented Sep 18, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.