GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Basic operators, math by betofc89 · Pull Request #247 · javascript-tutorial/pt.javascript.info

Conversation

@betofc89

@betofc89 betofc89 commented Aug 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Full translation of the section "Basic operators, math" to portuguese.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@betofc89
Translation of whole section
161d378
Full translation of the section "Basic operators, math" to brazilian portuguese.
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 12, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 12, 2022 14:23
@CLAassistant

CLAassistant commented Aug 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@betofc89 betofc89 changed the title Translation of whole section Translation of 1-js/02-first-steps/08-operators/ Aug 12, 2022
@betofc89 betofc89 mentioned this pull request Aug 12, 2022
Portuguese Translation Progress #1
Open
@betofc89 betofc89 changed the title Translation of 1-js/02-first-steps/08-operators/ Translation of "Basic operators, math" 1-js/02-first-steps/08-operators/ Aug 12, 2022
@betofc89 betofc89 changed the title Translation of "Basic operators, math" 1-js/02-first-steps/08-operators/ Translation of "Basic operators, math" (1-js/02-first-steps/08-operators/) Aug 12, 2022
@betofc89
Substituição por palavra mais precisa
ad5cdf0
No original em inglês é dito que "variables are not bound to any of them", se referindo ao fato de que as variáveis não estão limitadas (ou restritas) a nenhum data type. Acredito que o termo "vinculadas" não traduza tão claramente esta ideia. Acredito que a palavra "vinculada" seja muito ampla neste contexto e que a mesma deveria ser substituída por "restritas" ou "limitadas".

Por exemplo: suponha que Mário seja filho de Fabiana. Se nós dissermos que Mário está vinculado à Fabiana, estaremos certos, porque uma relação parental obviamente se refere a um vínculo. Mas se nós dissermos que Mário é *filho* de Fabiana, estaremos sendo ainda mais precisos, deixando pouco espaço para ambiguidades, já que *filho* traz uma ideia ainda mais específica. Se nós dissermos apenas que Mário possui um vínculo com Fabiana nós estaremos dando margem para alguém achar que Mário pode ser até mesmo o chefe de Fabiana. Se, porém, dissermos que Mário é *filho* de Fabiana, nós estaremos reduzindo o escopo dos possíveis vínculos, deixando tudo mais claro e preciso.
jonnathan-ls
jonnathan-ls requested changes Aug 13, 2022
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@betofc89, obrigado pela contribuição ❤️.

Segue minha revisão 😀.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

betofc89 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/08-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Aug 13, 2022
@javascript-translate-bot

javascript-translate-bot commented Aug 13, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Aug 13, 2022
@jonnathan-ls jonnathan-ls changed the title Translation of "Basic operators, math" (1-js/02-first-steps/08-operators/) Basic operators, math Aug 13, 2022
jonnathan-ls
jonnathan-ls requested changes Aug 13, 2022
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alteração em artigo diferente do propósito deste PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

betofc89 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/05-types/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot

javascript-translate-bot commented Aug 13, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

betofc89 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@betofc89

betofc89 commented Aug 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@betofc89, obrigado pela contribuição ❤️.

Segue minha revisão 😀.

@jonnathan-ls , isto sim é uma revisão de altíssimo nível! Muito obrigado mesmo pelas observações, correções e sugestões. Sinto que vou melhorar o meu português com as suas ótimas observações! Vou fazer as mudanças sugeridas por você.

Eu confesso que sou novo no GitHub e decidi contribuir com esta tradução até mesmo como forma de eu entender melhor GitHub/Git. Eu sempre tive vontade de colaborar em algum projeto open source, e achei que este aqui seria um excelente começo.

Sobre a alteração de outro artigo fora de contexto

Eu reverti aqui Revert "Substituição por palavra mais precisa" esta sugestão que fiz.

Por eu ser inexperiente com GitHub é que, por exemplo, a sugestão de alteração que fiz para o 05-types acabou ficando aqui no pull request do 08-operators. Peço desculpas por isto, e digo de coração que não foi por desleixo/preguiça que isto acabou ocorrendo. Na verdade, ontem mesmo eu percebi isto, e cheguei à conclusão de que eu deveria ter aberto outro pull request para manter tudo mais organizado. Porém, como esta sugestão de alteração já havia caído aqui no PR do 08-operators e como eu não sabia como desfazer isto, eu preferi deixar assim, por medo de bagunçar alguma coisa. Eu não sabia que enquanto um pull request está aberto, qualquer outro commit criado cairia dentro deste PR (estou certo em concluir isto?).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

betofc89 added 4 commits August 13, 2022 09:40
@betofc89
Typo-fix: space inserted between letters
4e7ed7f
A space was lacking between two letters.
@betofc89
Grammatical improvements
b3c65d6
The grammatical improvements proposed by @jonnathan-ls have been applied. They mainly consisted of the correct use of commas. There were also two small replacements of words.
@betofc89
Revert "Substituição por palavra mais precisa"
5d1c221
This reverts commit ad5cdf0.
@betofc89
Translation of task.md and solution.md files
93812d7
The `task.md` and `solution.md` files were translated into Portuguese for all challenges.
@betofc89

betofc89 commented Aug 13, 2022

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Aug 13, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 13, 2022 13:57
jonnathan-ls
jonnathan-ls requested changes Aug 16, 2022
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@betofc89 Nova revisão após tradução dos exercícios.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/02-first-steps/08-operators/4-fix-prompt/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Aug 16, 2022
@javascript-translate-bot

javascript-translate-bot commented Aug 16, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Aug 16, 2022
@jonnathan-ls

jonnathan-ls commented Aug 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@jonnathan-ls , isto sim é uma revisão de altíssimo nível!

@betofc89 Obrigado pela apreciação, é um prazer receber feedback ❤️
Por favor, fique a vontade também para pontuar qualquer observação que eu tenha feito equivocadamente ><

Eu confesso que sou novo no GitHub e decidi contribuir com esta tradução até mesmo como forma de eu entender melhor GitHub/Git. Eu sempre tive vontade de colaborar em algum projeto open source, e achei que este aqui seria um excelente começo.

Muito bom, está certíssimo. 🔝

Não faz tanto tempo que passei a contribuir com a tradução deste repositório, pretendo rever conceitos em JavaScript e me aprofundar mais na linguagem. Como gostei bastante da plataforma, decidi contribuir traduzindo, e acabei ingressando como revisor também.

... Eu não sabia que enquanto um pull request está aberto, qualquer outro commit criado cairia dentro deste PR (estou certo em concluir isto?).

Pertinente a comentário e a pergunta ... está certo em sua conclusão, isto por que está trabalhando direto na master e qualquer alteração fará parte do fluxo de desenvolvimento que já está realizando.

Para gerenciar melhor o trabalho recomendo seguir algum paradigma de fluxo de desenvolvimento, comentei mais detalhadamente sobre isso aqui: #247 (comment)

betofc89 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@betofc89
Undoing keyword translation for the exercises
b97f712
The keyword "importance" in the exercises should not be translated. Therefore, I'm undoing the translation of these keywords.
@betofc89

betofc89 commented Aug 25, 2022

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Aug 25, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 25, 2022 14:20
jonnathan-ls
jonnathan-ls approved these changes Aug 31, 2022
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Aug 31, 2022
@jonnathan-ls

jonnathan-ls commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

@betofc89 Obrigado pela correção, revisão aprovada ...

Para aprovação de mesclagem, é necessário mais um revisor... com aprovação de um segundo avaliador a PR será aceita.

betofc89 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

odsantos
odsantos requested changes Dec 5, 2022
View reviewed changes

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Please be free to tell where you disagree. Thanks, Osvaldo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/02-first-steps/08-operators/3-primitive-conversions-questions/solution.md
5. `null` becomes `0` after the numeric conversion.
6. `undefined` becomes `NaN` after the numeric conversion.
7. Space characters, are trimmed off string start and end when a string is converted to a number. Here the whole string consists of space characters, such as `\t`, `\n` and a "regular" space between them. So, similarly to an empty string, it becomes `0`.
1. A adição com uma string `"" + 1` converte `1` para uma string: `"" + 1 = "1"`, e então nós temos `"1" + 0`, a mesma regra é aplicada.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. A adição com uma string `"" + 1` converte `1` para uma string: `"" + 1 = "1"`, e então nós temos `"1" + 0`, a mesma regra é aplicada.
1. A adição de uma string `"" + 1` converte `1` para uma string: `"" + 1 = "1"`, e quando temos `"1" + 0`, a mesma regra é aplicada.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/3-primitive-conversions-questions/solution.md
6. `undefined` becomes `NaN` after the numeric conversion.
7. Space characters, are trimmed off string start and end when a string is converted to a number. Here the whole string consists of space characters, such as `\t`, `\n` and a "regular" space between them. So, similarly to an empty string, it becomes `0`.
1. A adição com uma string `"" + 1` converte `1` para uma string: `"" + 1 = "1"`, e então nós temos `"1" + 0`, a mesma regra é aplicada.
2. A subtração `-` (como a maioria das operações matemáticas) apenas funciona com números, esta converte uma string vazia `""` para `0`.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. A subtração `-` (como a maioria das operações matemáticas) apenas funciona com números, esta converte uma string vazia `""` para `0`.
2. A subtração `-` (como a maioria das operações matemáticas) apenas funciona com números, e converte uma string vazia `""` para `0`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/3-primitive-conversions-questions/solution.md
7. Space characters, are trimmed off string start and end when a string is converted to a number. Here the whole string consists of space characters, such as `\t`, `\n` and a "regular" space between them. So, similarly to an empty string, it becomes `0`.
1. A adição com uma string `"" + 1` converte `1` para uma string: `"" + 1 = "1"`, e então nós temos `"1" + 0`, a mesma regra é aplicada.
2. A subtração `-` (como a maioria das operações matemáticas) apenas funciona com números, esta converte uma string vazia `""` para `0`.
3. A adição com uma string anexa o número `5` à string.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. A adição com uma string anexa o número `5` à string.
3. A adição a uma string anexa o número `5` à string.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
```

What we should do is to convert strings to numbers before `+`. For example, using `Number()` or prepending them with `+`.
O que nós devemos fazer é converter strings em números antes do `+`. Por exemplo, usando `Number()` ou precedendo-os com `+`.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
O que nós devemos fazer é converter strings em números antes do `+`. Por exemplo, usando `Number()` ou precedendo-os com `+`.
O que nós devemos fazer é converter strings em números antes da adição (`+`). Por exemplo, usando `Number()` ou precedendo-os com `+`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/4-fix-prompt/solution.md
O que nós devemos fazer é converter strings em números antes do `+`. Por exemplo, usando `Number()` ou precedendo-os com `+`.

For example, right before `prompt`:
Por exemplo, logo antes de `prompt`:

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Por exemplo, logo antes de `prompt`:
Por exemplo, logo antes do `prompt`:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/article.md
Ambas as declarações fazem a mesma coisa: aumentam o `counter` em `1`.

Is there any difference? Yes, but we can only see it if we use the returned value of `++/--`.
Existe alguma diferença? Sim, mas só podemos vê-la se usarmos o valor retornado de `++/--`.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Existe alguma diferença? Sim, mas só podemos vê-la se usarmos o valor retornado de `++/--`.
Existe alguma diferença? Sim, mas só podemos vê-la se usarmos o valor retornado da operação `++/--`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/article.md
```

Though technically okay, such notation usually makes code less readable. One line does multiple things -- not good.
Embora tecnicamente correta, tal notação normalmente torna o código menos legível. Uma linha faz várias coisas -- nada bom.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Embora tecnicamente correta, tal notação normalmente torna o código menos legível. Uma linha faz várias coisas -- nada bom.
Embora tecnicamente correta, tal notação normalmente torna o código menos legível. Numa linha faz-se várias coisas -- nada bom.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/article.md
- ZERO-FILL RIGHT SHIFT ( `>>>` )

These operators are used very rarely, when we need to fiddle with numbers on the very lowest (bitwise) level. We won't need these operators any time soon, as web development has little use of them, but in some special areas, such as cryptography, they are useful. You can read the [Bitwise Operators](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Expressions_and_Operators#Bitwise) chapter on MDN when a need arises.
Estes operadores são muito raramente usados, quando nós precisamos mexer com números no nível mais baixo (bit a bit). Nós não precisaremos destes operadores em nenhum momento, já que desenvolvimento web faz pouco uso deles, mas em algumas áreas específicas, como em criptografia, eles são úteis. Você pode ler o capítulo [Operadores bit a bit](https://developer.mozilla.org/pt-BR/docs/Web/JavaScript/Guide/Expressions_and_Operators#operadores_bit_a_bit) na MDN quando surgir a necessidade.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Estes operadores são muito raramente usados, quando nós precisamos mexer com números no nível mais baixo (bit a bit). Nós não precisaremos destes operadores em nenhum momento, já que desenvolvimento web faz pouco uso deles, mas em algumas áreas específicas, como em criptografia, eles são úteis. Você pode ler o capítulo [Operadores bit a bit](https://developer.mozilla.org/pt-BR/docs/Web/JavaScript/Guide/Expressions_and_Operators#operadores_bit_a_bit) na MDN quando surgir a necessidade.
Estes operadores são muito raramente usados, e acontece quando nós precisamos mexer com números no nível mais baixo (bit a bit). Nós não precisaremos destes operadores dentro em breve, já que desenvolvimento web faz pouco uso deles, mas em algumas áreas específicas, como em criptografia, eles são úteis. Você pode ler o capítulo [Operadores bit a bit](https://developer.mozilla.org/pt-BR/docs/Web/JavaScript/Guide/Expressions_and_Operators#operadores_bit_a_bit) na MDN quando surgir a necessidade.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with eyes emoji
All reactions
  • 👀 1 reaction
Comment thread 1-js/02-first-steps/08-operators/article.md
Por que precisamos de um operador que descarta tudo exceto a última expressão?

Sometimes, people use it in more complex constructs to put several actions in one line.
Às vezes, as pessoas o usam e construtos mais complexos para pôr várias ações em uma linha.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Às vezes, as pessoas o usam e construtos mais complexos para pôr várias ações em uma linha.
Às vezes, as pessoas o usam em construções mais complexas para pôr várias ações em uma linha.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread 1-js/02-first-steps/08-operators/article.md
```

Such tricks are used in many JavaScript frameworks. That's why we're mentioning them. But usually they don't improve code readability so we should think well before using them.
Tais truques são usados em muitos frameworks JavaScript. É por isto que nós os estamos mencionando. Mas geralmente eles não melhoram a legibilidade do código de modo que nós precisamos pensar bem antes de usá-los.

@odsantos odsantos Dec 5, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tais truques são usados em muitos frameworks JavaScript. É por isto que nós os estamos mencionando. Mas geralmente eles não melhoram a legibilidade do código de modo que nós precisamos pensar bem antes de usá-los.
Tais truques são usados em muitos frameworks JavaScript. É por isto que nós os estamos mencionando. Mas geralmente eles não melhoram a legibilidade do código, de modo que nós precisamos pensar bem antes de usá-los.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@javascript-translate-bot javascript-translate-bot added the changes requested label Dec 5, 2022
@javascript-translate-bot

javascript-translate-bot commented Dec 5, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@odsantos

odsantos commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

Hi @betofc89 ,

I updated files in this branch according to the English version.
As part of the pending tasks, could you also resolve conflicts?

Thanks,
Osvaldo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Jan 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@odsantos since I don't have access to Beto's master branch, I forked his repo and fixed all remaining issues. Should I open a new PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@odsantos

odsantos commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

@odsantos since I don't have access to Beto's master branch, I forked his repo and fixed all remaining issues. Should I open a new PR?

Yes, please @peruibeloko could you open it? Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko peruibeloko mentioned this pull request Jan 3, 2024
Basic operators, maths #412
Merged
@peruibeloko

peruibeloko commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

@odsantos PR #412 is open!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nazarepiedady
nazarepiedady merged commit c3d9194 into javascript-tutorial:master Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantos odsantos odsantos requested changes
@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@betofc89 @CLAassistant @javascript-translate-bot @jonnathan-ls @odsantos @peruibeloko @nazarepiedady
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.