GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Basic operators, maths by peruibeloko · Pull Request #412 · javascript-tutorial/pt.javascript.info

Conversation

@peruibeloko

@peruibeloko peruibeloko commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Taking over PR #247

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
betofc89 and others added 8 commits August 12, 2022 11:19
@betofc89
Translation of whole section
161d378
Full translation of the section "Basic operators, math" to brazilian portuguese.
@betofc89
Substituição por palavra mais precisa
ad5cdf0
No original em inglês é dito que "variables are not bound to any of them", se referindo ao fato de que as variáveis não estão limitadas (ou restritas) a nenhum data type. Acredito que o termo "vinculadas" não traduza tão claramente esta ideia. Acredito que a palavra "vinculada" seja muito ampla neste contexto e que a mesma deveria ser substituída por "restritas" ou "limitadas".

Por exemplo: suponha que Mário seja filho de Fabiana. Se nós dissermos que Mário está vinculado à Fabiana, estaremos certos, porque uma relação parental obviamente se refere a um vínculo. Mas se nós dissermos que Mário é *filho* de Fabiana, estaremos sendo ainda mais precisos, deixando pouco espaço para ambiguidades, já que *filho* traz uma ideia ainda mais específica. Se nós dissermos apenas que Mário possui um vínculo com Fabiana nós estaremos dando margem para alguém achar que Mário pode ser até mesmo o chefe de Fabiana. Se, porém, dissermos que Mário é *filho* de Fabiana, nós estaremos reduzindo o escopo dos possíveis vínculos, deixando tudo mais claro e preciso.
@betofc89
Typo-fix: space inserted between letters
4e7ed7f
A space was lacking between two letters.
@betofc89
Grammatical improvements
b3c65d6
The grammatical improvements proposed by @jonnathan-ls have been applied. They mainly consisted of the correct use of commas. There were also two small replacements of words.
@betofc89
Revert "Substituição por palavra mais precisa"
5d1c221
This reverts commit ad5cdf0.
@betofc89
Translation of task.md and solution.md files
93812d7
The `task.md` and `solution.md` files were translated into Portuguese for all challenges.
@betofc89
Undoing keyword translation for the exercises
b97f712
The keyword "importance" in the exercises should not be translated. Therefore, I'm undoing the translation of these keywords.
@peruibeloko
Update PR with current master and resolve conflicts
c3d9194
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 3, 2024
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 3, 2024 21:03
@javascript-translate-bot

javascript-translate-bot commented Jan 3, 2024

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #1, it's 247 ⁉️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CLAassistant

CLAassistant commented Jan 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko peruibeloko mentioned this pull request Jan 3, 2024
Basic operators, math #247
Merged
@odsantos

odsantos commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

@peruibeloko the revision is under way. Thanks.

peruibeloko reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls
jonnathan-ls approved these changes Jan 7, 2024
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como este PR é um fork do #247, e contempla os commits contendo a revisão que eu já tinha aprovado anteriormente, estou deixando meu LGTM (Looks Good To Me)

Entretanto, registro esse comentário para confirmação e também para não ter confusão do porque de ter um segundo PR aberto de uma mesma tarefa ...

Pelo o que entendi dos comentários no PR 247, o colaborador @peruibeloko buscou resolver os conflitos e as revisões que você (@odsantos) sugeriu, certo? Nesse sentido, o PR anterior será encerrado e passaria a seguir por este, correto?

De qualquer modo @peruibeloko, não identifiquei as correções solicitadas pela revisão do @odsantos, conforme #247 (review)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jan 7, 2024
@peruibeloko

peruibeloko commented Jan 7, 2024

Copy link
Copy Markdown
Contributor Author

@jonnathan-ls obrigado pela aprovação! E sim, seria isso mesmo, esse PR assume de onde o anterior parou.

Eu tinha conferido pra ver se as correções do @odsantos já estavam no repo e parecia que sim, mas vou dar uma olhada aqui novamente.

jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Jan 7, 2024

Copy link
Copy Markdown
Contributor Author

@jonnathan-ls achei aqui onde eu fiz a confusão, eu achei que tinha trechos que faltavam traduzir, mas na verdade são mudanças na tradução em si!

Vou dar uma pausa rápida aqui pra jantar e já subo as alterações

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko
Add remaining requested changes
89ddea4
nazarepiedady
nazarepiedady approved these changes Jan 7, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine to me so for this reason I will approve it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nazarepiedady
nazarepiedady merged commit 846cbb1 into javascript-tutorial:master Jan 7, 2024
@javascript-translate-bot

javascript-translate-bot commented Jan 7, 2024

Copy link
Copy Markdown

Error: the article has another PR number in the Progress Issue #1, it's 247, not 412 ⁉️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Jan 7, 2024

Copy link
Copy Markdown
Contributor Author

@nazarepiedady I was about to list a couple of changes I did to @odsantos suggestions, but thanks for the early merge!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko
peruibeloko deleted the PR-247 branch January 7, 2024 04:01
@peruibeloko peruibeloko mentioned this pull request Jan 7, 2024
Status review for unfinished articles #416
Closed
@jonnathan-ls jonnathan-ls mentioned this pull request Jan 13, 2024
Portuguese Translation Progress #1
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedady nazarepiedady nazarepiedady approved these changes
@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@peruibeloko @javascript-translate-bot @CLAassistant @odsantos @nazarepiedady @jonnathan-ls @betofc89
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.