GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Methods of primitives by stevermeister · Pull Request #10 · javascript-tutorial/uk.javascript.info

Conversation

stevermeister commented May 8, 2019

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

stevermeister added 3 commits

May 8, 2019 10:26


          first try

2bf4a57


          cleanup + task translation

0bf5087


          grammar cleanup

471412a

CLAassistant commented May 8, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk reviewed

May 8, 2019

View reviewed changes

tarasyyyk left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevermeister you did a great work. I found some small remarks which need to be resolved before merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		@@ -1,22 +1,22 @@
		# Methods of primitives

tarasyyyk May 8, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Article title not translated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated


		- Is a value of a primitive type.
		- There are 6 primitive types: `string`, `number`, `boolean`, `symbol`, `null` and `undefined`.
		- є Is a value of a primitive type.

tarasyyyk May 8, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line "Is a value of a primitive type."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		З іншого боку, використання тих же самих функцій `String / Number / Boolean` без` new` є абсолютно розумною і корисною річчю. Вони перетворюють значення у відповідний тип: до рядка, числа або булевого (примітиву).

		Наприклад, це цілком справедливо:
		For example, this is entirely valid:

tarasyyyk May 8, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "For example, this is entirely valid:"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

stevermeister May 9, 2019

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not sure about good translation in this place, maybe you have ideas?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Наприклад, такий вираз цілком правильний:"
or
"Наприклад, це/так цілком правильно:"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stevermeister reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		Наприклад, це цілком справедливо:
		For example, this is entirely valid:
		```js
		let num = Number("123"); // convert a string to number

tarasyyyk May 8, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment also can be translated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		````

		## Summary
		## Виводи

tarasyyyk May 8, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to translate "Summary" as "Висновки" or "Підсумки"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stevermeister reacted with thumbs up emoji

All reactions

👍 1 reaction

iliakan mentioned this pull request

May 8, 2019

Ukrainian Translation Progress #1

Open


          cleanup

127a02d

tarasyyyk reviewed

May 9, 2019

View reviewed changes

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		З іншого боку, використання тих же самих функцій `String / Number / Boolean` без` new` є абсолютно розумною і корисною річчю. Вони перетворюють значення у відповідний тип: до рядка, числа або булевого (примітиву).

		Наприклад, це цілком справедливо:
		For example, this is entirely valid:

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Наприклад, такий вираз цілком правильний:"
or
"Наприклад, це/так цілком правильно:"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stevermeister reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		@@ -126,7 +126,7 @@ let num = Number("123"); // convert a string to number
		alert(null.test); // error

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translate comment: // помилка

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/1-string-new-property/solution.md Outdated

		Спробуйте запустити:

		```js run
		let str = "Hello";

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let str = "Привіт";

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/1-string-new-property/solution.md Outdated

		Ви можете отримати два результати:
		1. `undefined`
		2. An error.
		2. помилка.

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

помилку.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/1-string-new-property/task.md Outdated

		Розглянемо наступний код:

		```js
		let str = "Hello";

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let str = "Привіт";

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		Але за все потрібно платити!

		Objects are "heavier" than primitives. They require additional resources to support the internal machinery. But as properties and methods are very useful in programming, JavaScript engines try to optimize them to reduce the additional burden.
		Об'єкти "важче", ніж примітиви. Вони вимагають додаткових ресурсів для підтримки внутрішньої обробки. Але, оскільки властивості і методи дуже корисні в програмуванні, двигун JavaScript намагається оптимізувати їх для зменшення додаткового навантаження.

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Об'єкти "важчі" за примітиви.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		Ось як він працює:

		```js run
		let str = "Hello";

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let str = "Привіт";
...
// ПРИВІТ

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated

		1. The string `str` is a primitive. So in the moment of accessing its property, a special object is created that knows the value of the string, and has useful methods, like `toUpperCase()`.
		2. That method runs and returns a new string (shown by `alert`).
		3. The special object is destroyed, leaving the primitive `str` alone.
		1. Рядок `str` є примітивом. Тому під час звернення до його властивості створюється спеціальний об'єкт, який знає значення рядка і має корисні методи, такі як `toUpperCase ()`.

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toUpperCase() - without space

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated


		if (zero) { // zero is true, because it's an object
		if (zero) { // zero є true, тому що це об'єкт
		alert( "zero is truthy?!?" );

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alert( "чи zero є true?!?" );

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/01-primitives-methods/article.md Outdated


		On the other hand, using the same functions `String/Number/Boolean` without `new` is a totally sane and useful thing. They convert a value to the corresponding type: to a string, a number, or a boolean (primitive).

		З іншого боку, використання тих же самих функцій `String / Number / Boolean` без` new` є абсолютно розумною і корисною річчю. Вони перетворюють значення у відповідний тип: до рядка, числа або булевого (примітиву).

tarasyyyk May 9, 2019

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space before new

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          cleanup after review

4bc3284

stevermeister commented May 9, 2019

Copy link

Copy Markdown

Contributor Author

@tarasyyyk thank you for detailed review! all places were updated accordingly to the comments

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk added 2 commits

May 9, 2019 14:51


          small language correction

3d51eff


          small language corrections

3403c98

tarasyyyk merged commit 96163a4 into javascript-tutorial:master

May 9, 2019

tarasyyyk commented May 9, 2019

Copy link

Copy Markdown

Collaborator

@stevermeister found some fresh changes to English version:
javascript-tutorial/en.javascript.info@1ba420f
Would be good to translate them as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stevermeister commented May 9, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

@tarasyyyk yes, sure
here you are
https://github.com/javascript-tutorial/uk.javascript.info/pull/11/files

and could you please update untranslated parts of this repo with actual en origin?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot pushed a commit that referenced this pull request

Nov 11, 2019


          Update article.md

580221f

Adding some mention of implicit `<tbody>` element. Comes up later in Modifying the Document task #10 solution.

tarasyyyk commented Mar 6, 2020

Copy link

Copy Markdown

Collaborator

Thanks for your contribution!
@all-contributors add @stevermeister for translation.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

allcontributors Bot mentioned this pull request

Mar 6, 2020

docs: add stevermeister as a contributor #68

Merged

allcontributors Bot commented Mar 6, 2020

Copy link

Copy Markdown

Contributor

@tarasyyyk

I've put up a pull request to add @stevermeister! 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk changed the title ~~Data types > Methods of primitives~~ Methods of primitives

Aug 29, 2024

Reviewers

tarasyyyk

tarasyyyk left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

stevermeister commented May 8, 2019

Uh oh!

CLAassistant commented May 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarasyyyk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevermeister commented May 9, 2019

Uh oh!

tarasyyyk commented May 9, 2019

Uh oh!

stevermeister commented May 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarasyyyk commented Mar 6, 2020

Uh oh!

allcontributors Bot commented Mar 6, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CLAassistant commented May 8, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

stevermeister commented May 9, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.