GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Sb10ad fix synthesis.pyf by roryyorke · Pull Request #4 · jgoppert/Slycot

Conversation

@roryyorke

@roryyorke roryyorke commented Jun 28, 2015

Copy link
Copy Markdown

The sb10ad entry in synthesis.pyf did not infer ldac, ldab, ldac, ldad values from ac, bc, cc, dc, but instead looked like

    integer intent(hide), depend(ak) :: ldak=shape(ak,0)
    [... lines omitted]
    integer intent(hide), depend(ac) :: ldak=shape(ac,0)

The last line should be ldac, not ldak; the same bug is present for ldbc, etc.

I'm don't know enough about f2py to know if it should have raised a warning or error in this case.

Added a simple test for this case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
roryyorke added 2 commits June 28, 2015 12:57
@roryyorke
Fix: correct interface for sb10ad.
42cdeb8 
The fix is a bit of a guess, but after this the signature matches that
expected by synthesis.py's use of _wrapper.sb10ad, and a simple test
case works.
@roryyorke
Add test for sb10ad interface fix.
1a824f6 
Simple-as-possible test, with some reference values from Octave.
@roryyorke roryyorke mentioned this pull request Mar 9, 2016
Move away from SLICOT? python-control/python-control#27
Closed
jgoppert added a commit that referenced this pull request Mar 10, 2016
@jgoppert
Merge pull request #4 from roryyorke/sb10ad-fix-pyf
234447c 
Sb10ad fix synthesis.pyf
@jgoppert
jgoppert merged commit 234447c into jgoppert:master Mar 10, 2016
@roryyorke
roryyorke deleted the sb10ad-fix-pyf branch June 27, 2016 16:57
This was referenced Jun 27, 2016
control.robust.hinfsyn python-control/python-control#99
Closed
hinfsyn and h2syn fixes python-control/python-control#100
Merged
cwrowley pushed a commit to cwrowley/Slycot that referenced this pull request Dec 26, 2016
@slivingston
Merge pull request jgoppert#4 from roryyorke/rory-conda
a1f66bc 
Use conda for building (and consequently drop Py 2.6, 3.2, add 3.4, 3.5).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@roryyorke @jgoppert
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.