GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Recover error messages in eval_*() by ubaidsk · Pull Request #3380 · lfortran/lfortran

Conversation

@ubaidsk

@ubaidsk ubaidsk commented Feb 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

fixes #3325

closes #3129

closes #3328

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ubaidsk

ubaidsk commented Feb 9, 2024

Copy link
Copy Markdown
Member Author

This PR needs to be rebased after merging/completion of #3379.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ubaidsk
ubaidsk marked this pull request as ready for review February 9, 2024 10:26
@ubaidsk
ubaidsk requested a review from certik February 9, 2024 10:26
certik
certik approved these changes Feb 9, 2024
View reviewed changes

@certik certik left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this good, thanks for implementing this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@certik certik mentioned this pull request Feb 9, 2024
Remove nint, mod, huge from old runtime library and implement huge #3378
Merged
@ubaidsk
ubaidsk force-pushed the recover_err_msg branch from ee91cd3 to bf3d09b Compare February 10, 2024 02:13
ubaidsk added 3 commits February 10, 2024 07:55
@ubaidsk
Pass diagnostics as arg to eval_*()
1eaf4c6
@ubaidsk
Pass diag via the py script
820684b
@ubaidsk
Recover error messages back
ef3a6da
@ubaidsk
ubaidsk force-pushed the recover_err_msg branch from bf3d09b to ef3a6da Compare February 10, 2024 02:25
@ubaidsk
ubaidsk enabled auto-merge February 10, 2024 02:27
@ubaidsk
ubaidsk merged commit f6cdc6c into lfortran:main Feb 10, 2024
gxyd pushed a commit to gxyd/lfortran that referenced this pull request Mar 5, 2024
@ubaidsk
Merge pull request lfortran#3380 from Shaikh-Ubaid/recover_err_msg
bdb43eb
Recover error messages in eval_*()

Former-commit-id: f6cdc6c
gxyd pushed a commit to gxyd/lfortran that referenced this pull request Mar 5, 2024
@ubaidsk
Merge pull request lfortran#3380 from Shaikh-Ubaid/recover_err_msg
3ad33be
Recover error messages in eval_*()
certik pushed a commit to certik/lfortran that referenced this pull request Mar 5, 2024
@ubaidsk
Merge pull request lfortran#3380 from Shaikh-Ubaid/recover_err_msg
ff6d1c1
Recover error messages in eval_*()
@ubaidsk ubaidsk mentioned this pull request Sep 12, 2024
[Bug] [AST->ASR] Result is ok even when there is an error in diagnostics lcompilers/lpython#2810
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@certik certik certik approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intrinsics: port create_* functions to use the Python script Recover details in Error messages ASR intrinsics design improvements

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ubaidsk @certik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.