GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Refinement Declaration Positions by rcosta358 · Pull Request #287 · liquid-java/liquidjava

Fix Refinement Declaration Positions #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 3 commits into main from fix-ref-decl-positions
Sep 12, 2026

Uh oh!

There was an error while loading. Please reload this page.
Merged

Fix Refinement Declaration Positions #287

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83681ad
Fix Refinement Declaration Positions
rcosta358 Aug 25, 2026
c8dc18f
Exclude Quotes
rcosta358 Aug 25, 2026
90e3e52
Add New Line
rcosta358 Aug 25, 2026
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view
Prev Previous commit
Next Next commit
Exclude Quotes
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@rcosta358
rcosta358 committed Aug 25, 2026
commit c8dc18fd5bedd07cc0583cc12c35b64bcdfd58b9

There are no files selected for viewing

13 changes: 8 additions & 5 deletions 13 liquidjava-verifier/src/main/java/liquidjava/utils/Utils.java
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import spoon.reflect.declaration.CtMethod;
import spoon.reflect.factory.Factory;
import spoon.reflect.reference.CtTypeReference;
import spoon.support.reflect.cu.position.SourcePositionImpl;

public class Utils {

Expand Down Expand Up @@ -60,11 +61,13 @@ public static String getFile(CtElement element) {
// Get the position of the annotation with the given value
public static SourcePosition getLJAnnotationPosition(CtElement element, String value) {
String quotedValue = "\"" + value + "\"";
return getLiquidJavaAnnotations(element)
.flatMap(annotation -> getLJAnnotationValues(annotation)
.filter(expr -> quotedValue.equals(expr.toString()))
.map(expr -> expr.getPosition() != null ? expr.getPosition() : annotation.getPosition()))
.findFirst().orElse(element.getPosition());
return getLiquidJavaAnnotations(element).flatMap(annotation -> getLJAnnotationValues(annotation)
.filter(expr -> quotedValue.equals(expr.toString())).map(expr -> {
SourcePosition position = expr.getPosition();
return (SourcePosition) new SourcePositionImpl(position.getCompilationUnit(),
position.getSourceStart() + 1, position.getSourceEnd() - 1,
position.getCompilationUnit().getLineSeparatorPositions());
})).findFirst().orElse(element.getPosition());
}

// Get the position of the first value of the first LJ annotation on the element
Expand Down
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.