GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Add regression tests for records verified with an external spec by CatarinaGamboa · Pull Request #394 · liquid-java/liquidjava Conversation
Collaborator
Fixes #342 (regression tests only; no verifier change). At the commit in the issue, Fixtures, with the spec in its own file as in real projects:
Related gaps found while investigating, not fixed here:
Validation: 🤖 Generated with Claude Code
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…pec (#342) A record's methods were silently not verified when the project had an @ExternalRefinementsFor spec: the launcher parsed sources at compliance level 8, where JDT does not know records. It recovered by turning the record header into a method `record Repro(int attempts)` and the record's methods into locals and a block inside it, so the real methods never existed in the model; the verifier only emitted "Java compilation encountered issues" and then reported success. This is already fixed on main by reading the compliance level from the project's pom (#352), defaulting it to 21 with Spoon 11.5.0 (#368), and skipping records in the external-spec pass (#370). These directory cases keep the spec in its own file, as in the issue, and check a record whose methods violate (and respect) the Throwable typestate. Fixes #342 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Collaborator
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
rcosta358
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Soundness: the methods of a record are not verified when an external spec is presentUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |