GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Name refined call results after the method, as the other generated values by CatarinaGamboa · Pull Request #483 · liquid-java/liquidjava

Conversation

@CatarinaGamboa

@CatarinaGamboa CatarinaGamboa commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #477 (refs #373).

Problem

The result of a call to a method with a contract was still named #<method>_N, so messages showed it like a program variable: undoManager⁵⁵⁷ == getUndoManager⁵⁵⁵. All other generated values got descriptive names in #477.

Change

MethodsFunctionsChecker names those results with GeneratedNames.valueOf, like the other generated values: #<method>_result, and #new_<Class> for a refined constructor.

Study exercise Before After
A1_56 JabRef EditCommand.java:69 undoManager⁵⁵⁷ == getUndoManager⁵⁵⁵ undoManager⁵⁵⁷ == #getUndoManager_result⁵⁵⁵
A1_19 AccessKeyGenerator.java:17 dceSecurityNameRandom(randomUUID³⁸¹) dceSecurityNameRandom(#randomUUID_result³⁸¹)

Checked on the four exercises-oss study workspaces: only generated names change; no error appears, disappears or moves. Nothing depends on the old format: state checks compare the stored return-variable name, hints use method names, and the simplification and counterexample code check only the ## prefix.

Tests

  • TestGeneratedNames: the three condition messages now read #ready_result instead of ready.
  • Full suite locally: 690 tests, 0 failures. Codex review on the change: no findings.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CatarinaGamboa @claude
Name refined call results after the method, as the other generated va…
dbaa212
…lues

The result of a call to a method with a contract was named #<method>_N
and shown as getUndoManager⁵⁵⁵, like a program variable. It is now a
generated name, #getUndoManager_result⁵⁵⁵, as the results of the calls
inside an expression already were.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@CatarinaGamboa CatarinaGamboa added the study Needed before the error-message user study label Nov 4, 2026
@CatarinaGamboa
CatarinaGamboa merged commit 03b2d8b into main Nov 4, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.

@CatarinaGamboa CatarinaGamboa mentioned this pull request Nov 5, 2026
Write a call argument as the caller wrote it in refinement errors #486
Merged
CatarinaGamboa added a commit that referenced this pull request Nov 5, 2026
@CatarinaGamboa @claude
Write a call argument as the caller wrote it in refinement errors (#486)
9aa2467
## Problem

When a call argument is itself a call, the refinement error named its
value after the callee's parameter (`bound`), which is not in the
caller's code.

## Before / after

Issue reproducer (`return nextInt(size());`):

```
before: bound³ >= 0 is not a subtype of bound³ > 0
        Counterexample: bound³ == 0
after:  size()³ >= 0 is not a subtype of size()³ > 0
        Counterexample: size()³ == 0
```

Real case, fixture `classes/found_binders_error`
(`random.nextInt(items.size())`, as in chaos-http-proxy's
`failures.size()`):

```
before: bound⁶ == size(this.items) && bound⁶ >= 0 is not a subtype of bound⁶ > 0
        ∀bound⁶   bound⁶ == size(this.items) && bound⁶ >= 0
        Counterexample: bound⁶ == 0
after:  items.size()⁶ == size(this.items) && items.size()⁶ >= 0 is not a subtype of items.size()⁶ > 0
        ∀items.size()⁶   items.size()⁶ == size(this.items) && items.size()⁶ >= 0
        Counterexample: items.size()⁶ == 0
```

Nested calls: `nextInt(dec(size()))` gives `size()¹⁹ >= 0 &&
dec(size())²¹ == size()¹⁹ - 1 is not a subtype of dec(size())²¹ > 0`. An
unrefined call reads `plain()⁸ == #plain_result⁷` (result name from
#483).

The argument keeps its instance counter, like every other instance, so
two calls written alike (`between(next(), next())`) stay apart.

## Unchanged

Plain variables (`positive(t)`), field reads (`bound == this.f`), other
expressions (`bound == this.f - 1`) and literals keep the parameter
name: their refinement is `bound == <their code>`, so writing them as
code would read as a tautology (`0 == 0`, which `TestGeneratedNames`
would catch).

## How

Same approach as `FieldDisplayNames` (#459): `MethodsFunctionsChecker`
records the call's source text as written (Spoon's original source
fragment, so `count()` is not printed as `Basket.count()`) for the
argument instance in the new `ArgumentDisplayNames`.
`VariableFormatter.format` writes it with the counter, and
`ExpressionNameResolver` keeps it whole, as it does for fields
(`items.size()` is not cut to `size()`). A call with no source position
(built by Spoon, not read from a file) keeps the parameter name.
`CommandLineLauncher` clears the record at the start of each run. The
internal name and the SMT query are unchanged.

## Size

+68 / −7 over 7 files (main code +48 / −2; the new
`ArgumentDisplayNames` is 35 of those lines, most of them Javadoc).

## Tests

- `TestFoundBinders`: the reproducer's rows (also in the original step
of the history) now use `items.size()`; new
`callArgumentIsWrittenAsTheCallerWroteIt` on a new fixture line
`random.nextInt(count())`, checking the message and counterexample read
`count()`, not `bound` or `Basket.count()`.
- All of them fail on `main`, and the rows fail without the
`ExpressionNameResolver` change.
- `mvn test`: 693 tests, 0 failures.

Closes #481

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

study Needed before the error-message user study

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@CatarinaGamboa
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.