GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Show one state machine diagram per state set by CatarinaGamboa · Pull Request #163 · liquid-java/vscode-liquidjava

Conversation

@CatarinaGamboa

@CatarinaGamboa CatarinaGamboa commented Oct 26, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Closes #115. Uses liquidjava-fsm 0.2.1 (liquid-java/liquidjava-fsm#13).

Why

A class with several @StateSets, like ImageWriteParam with its tiling and compression states, was drawn as one diagram of the first state set. Every compression method ended up on the tiling diagram, and a compression error was marked on a tiling state: setCompressionQuality() in startCompression showed startTiling as rejected.

What

  • Server: liquidjava/fsm and StateRefinementErrorDTO now return one StateMachineDTO per state set (stateMachines, with a stateSet index), using StateMachineParser.parseAll from fsm 0.2.1.
    • The error context goes only on the diagrams whose transitions include the called method, and each one uses its own state set's part of the verifier's states.
    • A state is marked rejected only if no accepted state includes it, so a call that is rejected because of another state set doesn't blame this one. With one state set this gives the same marks as before.
  • View: the diagrams are stacked, each titled with its states. The diagram with the error comes first, and Focus on error dims the others. The summary combines the state sets the call involves. Copy Mermaid Source copies every diagram.
  • A class with one state set looks exactly as before.
  • The walkthrough mentions the per-state-set diagrams.

Arrows between state sets are left for later. A method that needs a state of the other state set keeps it as a condition, e.g. [compressionSet(this)].

Screenshots

Expert ImageWriteParam spec, in headless VS Code.

Tiling error: the tiling diagram comes first.

Tiling error

Focus on error: the compression diagram below it is dimmed.

Compression diagram dimmed

Compression error, before and after: before, it was drawn on the tiling diagram with startTiling marked rejected. Now it is on the compression diagram.

Before After
Before After

Show all:

Show all

Tests

  • Server: StateMachineDTOTest (new) and StateErrorContextDTOTest cover per-state-set marking and not blaming another state set. 34 tests pass.
  • Client: new specs for stacking, dimming, ordering and copying several diagrams, and for an error that cannot be marked (Keep the stepper and View error when a state error cannot be marked, and put State Machine next to Verification #161) on a class with several state sets. 105 unit tests pass, typecheck and lint are clean.
  • Integration (vscode-test): all 10 tests pass.

Rebased on main after #165. The screenshots are from the build after #161.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
CatarinaGamboa added a commit that referenced this pull request Oct 26, 2026
@CatarinaGamboa
Add screenshots for #163
dacc142
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/115-multiple-state-machines branch from 7e17de0 to 6ae57ef Compare October 26, 2026 11:33
CatarinaGamboa added a commit that referenced this pull request Oct 26, 2026
@CatarinaGamboa
Retake #163 screenshots after rebasing on #161
1f51742
CatarinaGamboa and others added 2 commits October 26, 2026 14:47
@CatarinaGamboa @claude
Send one state machine per state set from the language server
443e6fb
A class with several @stateset annotations, such as ImageWriteParam,
now has one diagram per state set. liquidjava/fsm returns the list from
liquidjava-fsm's parseAll, and a state refinement error carries
stateMachines instead of stateMachine.

The verifier names each state by its name in every state set, so the
error context of each diagram uses that state set's names. A state is
marked invalid only if no accepted state has it, so that a call like
write(), which needs a state in each state set, does not blame the
state set that is already right. The error is only put on the diagrams
of the state sets whose transitions have the called method.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@CatarinaGamboa @claude
Show one state machine diagram per state set
902f4e8
The State Machine view stacks the diagram of each state set of a class,
such as the tiling and compression states of ImageWriteParam, under the
class name, each labelled with its states. A class with one state set
looks as before.

A state error is drawn on the diagrams of the state sets it involves,
which come first, and focusing on it dims the other diagrams. The
summary lists the rejected states of every state set and the allowed
states each one needs. Copy Mermaid Source copies every diagram.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/115-multiple-state-machines branch from 6ae57ef to 902f4e8 Compare October 26, 2026 15:00
@CatarinaGamboa
CatarinaGamboa marked this pull request as ready for review October 26, 2026 15:02
@CatarinaGamboa
CatarinaGamboa merged commit 083e4db into main Oct 26, 2026
3 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@CatarinaGamboa CatarinaGamboa mentioned this pull request Oct 27, 2026
Show hints in state machine #156
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show one state machine diagram per @StateSet

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@CatarinaGamboa
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.