GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method by svegaxmr · Pull Request #100 · lmdbjava/lmdbjava

Conversation

@svegaxmr

@svegaxmr svegaxmr commented Jul 24, 2018

Copy link
Copy Markdown
Contributor

necessary for code like mdb_cursor_get(m_cur_block_heights, (MDB_val *)&zerokval, &val_h, MDB_GET_BOTH)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@svegaxmr
add cursor seek for MDB_GET_BOTH
a3b61be
@bp-alex

bp-alex commented Dec 7, 2018

Copy link
Copy Markdown
Member

Thanks for this PR. Would you mind please providing a corresponding test case?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bp-alex bp-alex added enhancement Additional or new functionality awaiting-response labels Dec 9, 2018
@bp-alex bp-alex removed the awaiting response label Dec 20, 2018
@svegaxmr

svegaxmr commented Jan 17, 2019

Copy link
Copy Markdown
Contributor Author

What is the highest version of Java that the tests can target?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Sylvyrfysh
Merge branch 'master' of https://github.com/lmdbjava/lmdbjava into cu…
7a70355 
…rsorget
@codecov-io

codecov-io commented Jan 25, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #100 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     90.98%   91.04%   +0.05%     
+ Complexity      373      352      -21     
============================================
  Files            29       28       -1     
  Lines          1265     1172      -93     
  Branches        113      106       -7     
============================================
- Hits           1151     1067      -84     
+ Misses           48       45       -3     
+ Partials         66       60       -6
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/lmdbjava/Cursor.java 80% <0%> (-10%) 25 <0> (ø)
src/main/java/org/lmdbjava/Verifier.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a927565...7a70355. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bp-alex
bp-alex force-pushed the master branch 11 times, most recently from 8809f8e to fed0c5d Compare April 15, 2020 05:03
bp-alex added a commit that referenced this pull request Apr 15, 2020
@bp-alex
Add test for PR #100
a781bb2
@bp-alex
bp-alex merged commit e5f5008 into lmdbjava:master Apr 15, 2020
@bp-alex bp-alex changed the title add cursor seek for MDB_GET_BOTH Add Cursor.get(BufferProxy, BufferProxy, SeekOp) method Apr 15, 2020
@bp-alex

bp-alex commented Apr 15, 2020

Copy link
Copy Markdown
Member

Thanks for the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Additional or new functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@svegaxmr @bp-alex @codecov-io @Sylvyrfysh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.