GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — APIGW: fix Integration connectionId not being returned by bentsku · Pull Request #13233 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@bentsku

@bentsku bentsku commented Oct 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Motivation

This has been reported with #13218

We are forwarding calls to PutIntegration to moto, but it doesn't save the connectionId parameter when the integration is of type VPC_LINK.

The linked issue is a bigger one, as LocalStack does not support NLB yet, so we technically don't fully support APIGW Private Integration with VPC Links, as it requires a link to the NLB via targetArns, but are not validating this as of now.

See https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-api-with-vpclink-cli.html

Changes

  • attach the connectionId to the moto model to be able to retrieve in get_integration
  • add validated test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bentsku
fix connectionId not being returned
b578528
@bentsku bentsku added this to the 4.10 milestone Oct 7, 2025
@bentsku bentsku self-assigned this Oct 7, 2025
@bentsku bentsku added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 7, 2025
@github-actions

github-actions Bot commented Oct 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 298 tests  +6   20 555 ✅ +6   16m 27s ⏱️ +53s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit a494e53. ± Comparison against base commit 928f470.

This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both. 
tests.unit.test_common.TestCommon ‑ test_is_number

tests.unit.test_common.TestCommon ‑ test_is_number[-12.1-True]
tests.unit.test_common.TestCommon ‑ test_is_number[2000000000000000.0-True]
tests.unit.test_common.TestCommon ‑ test_is_number[5-True]
tests.unit.test_common.TestCommon ‑ test_is_number[False-False]
tests.unit.test_common.TestCommon ‑ test_is_number[None-False]
tests.unit.test_common.TestCommon ‑ test_is_number[True-False]
tests.unit.test_common.TestCommon ‑ test_is_number[test-False]

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   16m 22s ⏱️ - 1h 42m 41s
1 163 tests  - 3 632  1 095 ✅  - 3 364  68 💤  - 268  0 ❌ ±0 
1 165 runs   - 3 632  1 095 ✅  - 3 364  70 💤  - 268  0 ❌ ±0 

Results for commit a494e53. ± Comparison against base commit 928f470.

This pull request removes 3633 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApigatewayIntegration ‑ test_create_integration_with_vpc_link

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 19s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit a494e53. ± Comparison against base commit 928f470.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   35m 25s ⏱️ - 2h 3m 8s
1 187 tests  - 3 982  1 120 ✅  - 3 553  67 💤  - 429  0 ❌ ±0 
1 193 runs   - 3 982  1 120 ✅  - 3 553  73 💤  - 429  0 ❌ ±0 

Results for commit a494e53. ± Comparison against base commit 928f470.

This pull request removes 3983 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApigatewayIntegration ‑ test_create_integration_with_vpc_link

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bentsku
bentsku marked this pull request as ready for review October 7, 2025 11:26
@bentsku
bentsku requested a review from cloutierMat as a code owner October 7, 2025 11:26
@bentsku bentsku mentioned this pull request Oct 7, 2025
bug: Api integration deployed with configured connection id does not set connection id in localstack #13218
Closed
1 task done
cloutierMat
cloutierMat approved these changes Oct 7, 2025
View reviewed changes

@cloutierMat cloutierMat left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this.

I just left one comment regarding update_integration. I think the update method itself will work and update the value, but we should probably also add it to the returned values. Once that is added we are good to go! 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bentsku reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread localstack-core/localstack/services/apigateway/legacy/provider.py

return response

def update_integration(

@cloutierMat cloutierMat Oct 7, 2025

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably return the value in update integration as well as it might impact some Terraform code somewhere 😉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bentsku reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@bentsku bentsku Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, will update 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bentsku
also fix connectionId for UpdateIntegration
a494e53
@bentsku
bentsku merged commit b2694a8 into main Oct 8, 2025
@bentsku
bentsku deleted the fix-vpc-link-id branch October 8, 2025 12:15
baermat pushed a commit that referenced this pull request Oct 13, 2025
@bentsku @baermat
APIGW: fix Integration connectionId not being returned (#13233)
b39fe32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@cloutierMat cloutierMat cloutierMat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@bentsku bentsku

Labels

aws:apigateway Amazon API Gateway docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.10

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bentsku @cloutierMat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.