GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CFn: handle get_template_summary of failed stack deploy by simonrw · Pull Request #13239 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@simonrw

@simonrw simonrw commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Motivation

While triaging issues, we found that the error

    for resource_id, resource in template[""Resources""].items():
                                 ~~~~~~~~^^^^^^^^^^^^^
localstack.aws.api.core.CommonServiceException: exception while calling cloudformation.GetTemplateSummary: 'NoneType' object is not subscriptable

was encountered and shown to be quite common. This occurs because we do not correctly set the change set template on the stack if the stack fails to deploy.

Changes

  • Raise validation error for get_template_summary if the template body does not include the Resources field (discovered as a separate bug while investigating the real bug)
  • Handle not setting template after execute_change_set

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
simonrw added 2 commits October 7, 2025 23:33
@simonrw
Handle validation error for get_template_summary
023d791
@simonrw
Handle not setting template after execute_change_set
90ddbfe
@simonrw simonrw added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 7, 2025
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

Test Results - Preflight, Unit

22 292 tests  ±0   20 549 ✅ ±0   15m 47s ⏱️ +8s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 90ddbfe. ± Comparison against base commit b592fbd.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 90ddbfe. ± Comparison against base commit b592fbd.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   35m 24s ⏱️ - 1h 25m 23s
578 tests  - 4 224  463 ✅  - 4 001  115 💤  - 223  0 ❌ ±0 
580 runs   - 4 224  463 ✅  - 4 001  117 💤  - 223  0 ❌ ±0 

Results for commit 90ddbfe. ± Comparison against base commit b592fbd.

This pull request removes 4226 and adds 2 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.api.test_templates ‑ test_get_template_summary_failed_stack
tests.aws.services.cloudformation.api.test_templates ‑ test_get_template_summary_no_resources
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   48m 18s ⏱️
602 tests 488 ✅ 114 💤 0 ❌
608 runs  488 ✅ 120 💤 0 ❌

Results for commit 90ddbfe.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

Test Results - Alternative Providers

577 tests   330 ✅  25m 59s ⏱️
  1 suites  247 💤
  1 files      0 ❌

Results for commit 90ddbfe.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@simonrw
simonrw marked this pull request as ready for review October 8, 2025 08:45
@simonrw
simonrw requested review from dominikschubert and pinzon as code owners October 8, 2025 08:45
pinzon
pinzon approved these changes Oct 8, 2025
View reviewed changes

@pinzon pinzon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's great that you added more than just one validation test 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@simonrw
simonrw merged commit c2e408c into main Oct 8, 2025
@simonrw
simonrw deleted the cfn/get-template-summary-failed-stack branch October 8, 2025 17:48
baermat pushed a commit that referenced this pull request Oct 13, 2025
@simonrw @baermat
CFn: handle get_template_summary of failed stack deploy (#13239)
479cbc0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner
1 more reviewer
@pinzon pinzon pinzon approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@simonrw @pinzon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.