GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Step Functions: fix validate-state-machine-definition by YukiMichishita · Pull Request #13281 · localstack/localstack

This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Conversation

@YukiMichishita

@YukiMichishita YukiMichishita commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Motivation

Fixes Step Functions definition validation issues #12958 and #13171. Details and rationale are in the original issues.

Changes

  • Add failing test reproducing bug: validate-state-machine-definition rejects valid state machine definitions #12958, then implement the fix.
  • Reorder tests to expose Bug: validate-state-machine-definition produces non-deterministic results for identical input #13171, then fix non-deterministic validator state.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@YukiMichishita
YukiMichishita requested review from dominikschubert, gregfurman and joe4dev as code owners October 19, 2025 07:48
localstack-bot
localstack-bot reviewed Oct 19, 2025
View reviewed changes

@localstack-bot localstack-bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@localstack-bot

localstack-bot commented Oct 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@YukiMichishita

YukiMichishita commented Oct 19, 2025

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
localstack-bot added a commit that referenced this pull request Oct 19, 2025
@localstack-bot
@YukiMichishita has signed the CLA in #13281
25e8f20
@gregfurman gregfurman self-assigned this Oct 20, 2025
@gregfurman gregfurman added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes aws:stepfunctions AWS Step Functions labels Oct 20, 2025
gregfurman
gregfurman approved these changes Nov 20, 2025
View reviewed changes

@gregfurman gregfurman left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the neat contribution (and patience 🙂) on this PR 🚀

Unsure whether this will fix #13171 though, but let's rather discuss on that issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
YukiMichishita added 5 commits November 20, 2025 11:11
@YukiMichishita @gregfurman
add:test cases for issue#12958
30e9a3a
@YukiMichishita @gregfurman
fix:validation of query language in step functions
4e17275
@YukiMichishita @gregfurman
change tests order to show issue#13171
b605a85
@YukiMichishita @gregfurman
fix:validate-state-machine-definition's non-deterministic behavior
06826d8
@YukiMichishita @gregfurman
add test cases for express statemachine
a8604e4
@gregfurman
gregfurman force-pushed the resolve-issue-12958-13171 branch from fa58564 to a8604e4 Compare November 20, 2025 09:11
@gregfurman gregfurman changed the title Step Functions: fix validate-state-machine-definition for #12958 and #13171 Step Functions: fix validate-state-machine-definition Nov 20, 2025
@gregfurman
gregfurman merged commit ae5c685 into localstack:main Nov 20, 2025
38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@tiurin tiurin mentioned this pull request Jan 15, 2026
bug: validate-state-machine-definition rejects valid state machine definitions #12958
Closed
1 task done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert
@joe4dev joe4dev Awaiting requested review from joe4dev
2 more reviewers
@localstack-bot localstack-bot localstack-bot left review comments
@gregfurman gregfurman gregfurman approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gregfurman gregfurman

Labels

aws:stepfunctions AWS Step Functions docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@YukiMichishita @localstack-bot @gregfurman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.