GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve line location report for invalid qualifier for SubclassMapping · Issue #3202 · mapstruct/mapstruct

Improve line location report for invalid qualifier for SubclassMapping #3202

New issue
Copy link
New issue
Copy link
Closed
#3204
Closed
Improve line location report for invalid qualifier for SubclassMapping#3202
#3204
Copy link
Labels
enhancementgood first issue
Milestone
1.6.0.Beta1

Description

@filiphr
filiphr
opened on Mar 17, 2023
Issue body actions

In PR #3120 we added support for qualifiedBy and qualifiedByName. Our generic logic seems like it is putting the error line location on the method element itself. We should instead use the @SubclassMapping element for reporting the error.

This issue is a good issue to get started with MapStruct. If the original creator of the PR @EvaristeGalois11 is not interested in adding this, then I would invite someone from the community to give it a go.

Activity

  1. filiphr
    added
    enhancement
    good first issue
    on Mar 17, 2023
  2. EvaristeGalois11 commented on Mar 17, 2023

    @EvaristeGalois11
    EvaristeGalois11
    on Mar 17, 2023
    Contributor
    More actions

    Yep no problem, i'll give it a try! 🚀

  3. EvaristeGalois11
    added a commit that references this issue on Mar 18, 2023

    mapstruct#3202 Improve line location report for invalid qualifier for…

    feaf190
  4. filiphr
    added this to the 1.6.0 milestone on Apr 16, 2023
  5. EvaristeGalois11
    added a commit that references this issue on Apr 16, 2023

    mapstruct#3202 Improve line location report for invalid qualifier for…

    d989a9d
  6. filiphr
    closed this as completedin #3204on Apr 22, 2023
  7. filiphr
    added a commit that references this issue on Apr 22, 2023

    #3202 Improve line location report for invalid qualifier for Subclass…

    b1034e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementgood first issue

    Type

    No type

    Projects

    No projects

      Milestone

      • 1.6.0.Beta1

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.