Description

gunnarmorling

opened on Jan 22, 2015

Issue body actions

• In @Mapper#componentModel() there could be shown the list of supported values
• In @Mapper#config() there could be shown a filtered list only containing actual config classes
• In @InheritConfiguration#name()/@InheritInverseConfiguration#name() there could be shown a filtered list of existing method names - handled in Code completion: add completion for InheritConfiguration/InheritInverseConfiguration methods #22
• @Mapper#dependsOn() should suggest only properties of the target bean - handled in Code completion: add proposals for @Mapping#dependsOn #23

Activity

1. gunnarmorling

   added

   feature

   on Mar 8, 2015
2. sradi commented on Mar 16, 2015

   

   sradi

   on Mar 16, 2015

   More actions

   I implemented the auto-completion for @Mapper#componentModel() (see https://github.com/sradi/mapstruct-eclipse/tree/issue7_componentModel). The list of supported values is currently hard coded. Other suggestions are welcome.
   Before sending a pull request, I'd appreciate feedback on the structural changes, that I made.
3. sradi

   self-assigned this

   on Mar 17, 2015
4. gunnarmorling commented on Mar 19, 2015

   

   gunnarmorling

   on Mar 19, 2015

   MemberAuthor

   More actions

   @sradi, sorry for the late reply.

   Could you create a pull request also if its in an early stage? Then we have a place where we can discuss it and it isn't at risk of being forgotten ;) You can then still push further commits for incorporating any review comments if needed.

   Thanks a lot for your contribution, looking forward to merge your first commit :)
5. gunnarmorling commented on Mar 19, 2015

   

   gunnarmorling

   on Mar 19, 2015

   MemberAuthor

   More actions

   Btw. @agudian fixed a bug fix for completion of bean properties, so your change probably needs a rebase.
6. sradi commented on Mar 20, 2015

   

   sradi

   on Mar 20, 2015

   More actions

   I'd like to start work on auto-completion for @Mapper#config.
   @larswetzer, I have a question on how to solve this: Do you think, it's a good idea to use the SearchEngine of JDT to find all classes, that are annotated with @MapperConfig or is there a simpler way to find valid auto-completions for this?
7. wetzer commented on Mar 22, 2015

   

   wetzer

   on Mar 22, 2015

   Member

   More actions

   @sradi, first of all, thanks a lot for your contribution!

   I’m not sure whether the JDT search engine performs well in context of content assist, especially if the index is not yet built. But you should give it a try and test the performance.

   Another idea would be an iteration over all compilation units of the project and do some AST parsing afterwards.
8. sradi

   added 2 commits that reference this issue on Apr 26, 2015

   #7 Extracting AbstractAnnotationCompletionProposalComputer

   990660f

   #7 Adding CompletionProposalComputer for @Mapper annotation

   8ffa12e
9. gunnarmorling

   added a commit that references this issue on Apr 26, 2015

   #7 JavaDoc adjustments

   797ce50
10. agudian commented on May 2, 2015

    

    agudian

    on May 2, 2015

    Member

    More actions

    I've moved out some parts of the todo-list to separate issues.
11. gunnarmorling commented on Nov 13, 2015

    

    gunnarmorling

    on Nov 13, 2015

    MemberAuthor

    More actions

    Hey @sradi just came across this issue. Would you still be interested in working on this?
12. sradi commented on Nov 26, 2015

    

    sradi

    on Nov 26, 2015

    More actions

    Hi @gunnarmorling , I just had a closer look into my work-in-progress from a couple of months ago. My first intent was to finish this issue. But at a second glance, the code completion feature doesn't seem trivial to implement for non-String values (in this case: @Mapper(config=...)).
    The current implementation of AbstractAnnotationCompletionProposalComputer.isInRange(...) doesn't work properly, when the compilationUnit is not in a compileable state (compilationUnit.isStructureKnown()==false).
    If @larswetzer has any hints, that help me to find an easy solution, I would happily implement it. But I currently don't have the time to get a deeper understanding of JDT.
13. agudian

    added 7 commits that reference this issue on Apr 18, 2016

    mapstruct#7 Add some Screenshots

    497983c

    mapstruct#7 Add some Screenshots

    a56e6cc

    mapstruct#7 Add some Screenshots

    6730670

    mapstruct#7 Add some Screenshots

    3ffd837

    mapstruct#7 Add some Screenshots

    014866d

    mapstruct#7 Add some Screenshots to README.md

    678091a

    mapstruct#7 Add some Screenshots to README.md

    be3dbdc

Issue actions