GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — the affine matrix is calculated in the display coordinate for interpolation='none' by leejjoon · Pull Request #1150 · matplotlib/matplotlib

Conversation

leejjoon commented Aug 27, 2012

Copy link

Copy Markdown

Contributor

For images with interpolation='none', the affine matrix is now calculated in the display coordinate.
This is to simplify the matrix that renderers receives.
This is to address #1085.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          for interpolation='none', the affine matrix is calculated in the disp…

96ac546

…lay coordinate

pelson commented Sep 2, 2012

Copy link

Copy Markdown

Member

If you have code that was failing, but is now fixed, it would be great to get a test for this new code.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mdboom commented Sep 4, 2012

Copy link

Copy Markdown

Member

I'd love to see this go into 1.2.x. I will try to whip up a test based on #1085 for this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Add test for matplotlib#1150.

46cd29a

mdboom commented Sep 4, 2012

Copy link

Copy Markdown

Member

I've added a test as a PR against @leejjoon's branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge pull request #3 from mdboom/fix-image-shift

67eb71d

Add test for matplotlib#1150.

travisbot commented Sep 5, 2012

Copy link

Copy Markdown

This pull request fails (merged 67eb71d into 94c53e1).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pelson commented Sep 5, 2012

Copy link

Copy Markdown

Member

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mdboom added a commit that referenced this pull request

Sep 5, 2012


          Merge pull request #1150 from leejjoon/fix-image-shift

2e5a38a

the affine matrix is calculated in the display coordinate for interpolation='none'

mdboom merged commit 2e5a38a into matplotlib:master

Sep 5, 2012

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.2.x

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.