GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Raise NotImplementedError with equal aspect on 3D axes by dstansby · Pull Request #13474 · matplotlib/matplotlib

Conversation

@dstansby

@dstansby dstansby commented Feb 20, 2019

Copy link
Copy Markdown
Member

See #1077. Until it is implemented properly, it seems reasonable to raise a NotImplementedError (and not a warning, because trying to set an equal aspect results in nonsense: #1077 (comment))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anntzer
anntzer reviewed Feb 20, 2019
View reviewed changes
Comment thread lib/matplotlib/axes/_base.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
jklymak
jklymak reviewed Feb 20, 2019
View reviewed changes

@jklymak jklymak left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to warn or log.info.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anntzer

anntzer commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

(I'm in favor of actually throwing an exception, given that the resulting plot is just plain wrong.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dstansby
Raise NotImplementedError when setting aspect on 3D axes
29b048f
@dstansby
dstansby force-pushed the 3d-equal-aspect branch from 47a3d86 to 29b048f Compare February 20, 2019 20:30
anntzer
anntzer approved these changes Feb 21, 2019
View reviewed changes
@jklymak

jklymak commented Feb 21, 2019

Copy link
Copy Markdown
Member

I meant warn and not set the aspect ratio, not warn and do something buggy 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dstansby dstansby added the topic: mplot3d label Feb 21, 2019
@anntzer

anntzer commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Right now we raise if someone does set_aspect("foobar"); I think passing "equal" to 3D axes is essentially the same.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
timhoffm
timhoffm approved these changes Feb 21, 2019
View reviewed changes
@timhoffm
timhoffm merged commit f8f6fdf into matplotlib:master Feb 21, 2019
@dstansby
dstansby deleted the 3d-equal-aspect branch February 21, 2019 17:52
@jklymak jklymak mentioned this pull request Mar 3, 2019
3d plots with aspect='equal' #1077
Closed
@QuLogic QuLogic added this to the v3.1.0 milestone Jul 24, 2019
@heavelock heavelock mentioned this pull request Aug 9, 2019
NotImplementedError with equal aspect on 3D axes introduced in Matplotlib 3.1.0 obspy/obspy#2437
Closed
kip-hart pushed a commit to kip-hart/MicroStructPy that referenced this pull request Sep 12, 2019
Hart, Kenneth Arthur
avoiding matplotlib 3.1 for 3d axes equal
56fbdb4 
matplotlib/matplotlib#13474
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Oct 4, 2019
3D axes set_aspect("equal") NotImplementedError #15382
Closed
ftherrien pushed a commit to ftherrien/p2ptrans that referenced this pull request Jan 15, 2020
Félix Therrien
Fixed the matplotlib 3D set_aspect('equal') issue
25c4dbd 
The NotImplemented error was caused by the fact that set_aspect now causes an error in matplotlib (see matplotlib/matplotlib#1077 and matplotlib/matplotlib#13474). Fixed by making the figure itself square such that the 3D axis are square.

Also change the fortan module's name from p2ptrans to fmodules which prevented from importing p2ptrans as a python module.
SenorPez added a commit to SenorPez/glowing-potato that referenced this pull request Jan 28, 2020
@SenorPez
Fix for change in up-to-date matplot lib. See matplotlib/matplotlib#1…
1213cf2 
…3474
This was referenced Feb 25, 2020
Open Interfaces unexpected exception mantidproject/mantid#28050
Closed
Fix Interface Opening Exceptions mantidproject/mantid#28065
Merged
@dstansby dstansby mentioned this pull request Apr 17, 2020
set_aspect for 3D plots #17172
Closed
@VinceBaz VinceBaz mentioned this pull request Jun 18, 2021
Add custom_aspect parameter to plot_point_brain. netneurolab/netneurotools#104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak left review comments
@anntzer anntzer anntzer approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: mplot3d

Projects

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@dstansby @anntzer @jklymak @timhoffm @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.