GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move mplot3d autoregistration api changes to 3.2. by anntzer · Pull Request #16272 · matplotlib/matplotlib

Conversation

@anntzer

@anntzer anntzer commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

This was wrongly put into the 3.1 notes.

Closes #16192.

Should perhaps also be backported to 3.1.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anntzer
Move mplot3d autoregistration api changes to 3.2.
4cbe134 
This was wrongly put into the 3.1 notes.
@anntzer anntzer added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Jan 20, 2020
@anntzer anntzer added this to the v3.2.0 milestone Jan 20, 2020
dstansby
dstansby approved these changes Jan 21, 2020
View reviewed changes
@dstansby dstansby modified the milestones: v3.2.0, v3.1-doc Jan 21, 2020
@dstansby
dstansby merged commit ef57d9e into matplotlib:master Jan 21, 2020
@lumberbot-app

lumberbot-app Bot commented Jan 21, 2020

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 ef57d9ef82ec069f1093bc69e3db2b658a9407d0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16272: Move mplot3d autoregistration api changes to 3.2.'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-16272-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #16272 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lumberbot-app lumberbot-app Bot added the Still Needs Manual Backport label Jan 21, 2020
@lumberbot-app

lumberbot-app Bot commented Jan 21, 2020

Copy link
Copy Markdown

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
anntzer deleted the mplot3dautoregister branch January 21, 2020 11:35
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Feb 13, 2020
@dstansby @QuLogic
Backport PR matplotlib#16272: Move mplot3d autoregistration api chang…
f7832e8 
…es to 3.2.
@QuLogic

QuLogic commented Feb 13, 2020

Copy link
Copy Markdown
Member

Well, this isn't getting into 3.1.3, but might as well backport to fix the website.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic QuLogic mentioned this pull request Feb 13, 2020
Backport PR #16272 on branch v3.1.3-doc #16488
Merged
@QuLogic

QuLogic commented Feb 13, 2020

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.2.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 13, 2020
Backport PR #16272 on branch v3.2.x (Move mplot3d autoregistration api changes to 3.2.) #16489
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 13, 2020
@dstansby @meeseeksmachine
Backport PR matplotlib#16272: Move mplot3d autoregistration api chang…
a9ce19c 
…es to 3.2.
dstansby added a commit that referenced this pull request Feb 13, 2020
@dstansby
Merge pull request #16489 from meeseeksmachine/auto-backport-of-pr-16…
0f26bf4 
…272-on-v3.2.x

Backport PR #16272 on branch v3.2.x (Move mplot3d autoregistration api changes to 3.2.)
@timhoffm timhoffm removed the Still Needs Manual Backport label Feb 16, 2020
@timhoffm

timhoffm commented Feb 16, 2020

Copy link
Copy Markdown
Member

I think backporting to v3.2.x is enough.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tacaswell added a commit that referenced this pull request Feb 16, 2020
@tacaswell
Merge pull request #16488 from QuLogic/auto-backport-of-pr-16272-on-v…
6eb0573 
…3.1.3-doc

Backport PR #16272 on branch v3.1.3-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstansby dstansby dstansby approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.1-doc

Development

Successfully merging this pull request may close these issues.

matplotlib 3.1.2: mplot3d must be explicitly imported to work

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@anntzer @QuLogic @timhoffm @dstansby
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.