GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix hist for log=True and histtype='step' by dmcdougall · Pull Request #1684 · matplotlib/matplotlib

Conversation

@dmcdougall

@dmcdougall dmcdougall commented Jan 19, 2013

Copy link
Copy Markdown
Member

Rebased version of #1029 to target v1.2.x. This aims to fix #196 but is currently incomplete.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
keflavich and others added 3 commits January 18, 2013 18:38
@keflavich @dmcdougall
Implemented fix to issue 196 on github for log=True and histtype='step'
e6a9145
@keflavich @dmcdougall
fixed the minimum specification in ax.hist as per @WeatherGod's comment;
e574c11
only want to set min this way if log is specified.  Also, added case for
normed vs not
@dmcdougall
Use numpy.min
83f3ff9
@dmcdougall

dmcdougall commented Jan 19, 2013

Copy link
Copy Markdown
Member Author

Over in #1029 there was discussion of using the log's actual base rather than the magical number 0.1. This would be the correct solution aside from the fact that the axis scale is set to base ten inside hist (it's the default). If the user then changes the [xy]scale outside of hist, how do we change the plot to reflect the change of base without calling hist again?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@WeatherGod

WeatherGod commented Jan 20, 2013

Copy link
Copy Markdown
Member

I wouldn't worry too much about a situation where the log base changes
after the call to hist. A lot of stuff breaks if you do any sort of
rescaling after the call to hist, and if it isn't already, it should be
well documented to establish your scales prior to any plotting.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmcdougall added 2 commits January 20, 2013 13:20
@dmcdougall
Add hist step log test
4aa17a7
@dmcdougall
Use actual log base, instead of assuming a default
2ca68c6
@dmcdougall

dmcdougall commented Jan 20, 2013

Copy link
Copy Markdown
Member Author

@WeatherGod Alright, thanks for that information.

Are there any other concerns that need to be addressed before this is merged? All tests pass locally on python 2.7.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dmcdougall
Upate comments in hist to be more descriptive
d1c9bb4
dmcdougall added a commit that referenced this pull request Jan 27, 2013
@dmcdougall
Merge pull request #1684 from dmcdougall/fix_loghist
2dc2825
Fix hist for log=True and histtype='step'
@dmcdougall
dmcdougall merged commit 2dc2825 into matplotlib:v1.2.x Jan 27, 2013
@dmcdougall
dmcdougall deleted the fix_loghist branch January 27, 2013 18:09
This was referenced Jan 27, 2013
Implemented fix to issue 196 on github for log=True and histtype='step' #1029
Closed
Axes.hist(...log=True) mishandles y-axis minimum value #196
Closed
fix hist limit issue for step* for both linear and log scale #1075
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dmcdougall @WeatherGod @keflavich
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.