GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixing OSX makefile by fgb · Pull Request #17 · matplotlib/matplotlib

Conversation

@fgb

@fgb fgb commented Feb 23, 2011

Copy link
Copy Markdown
Contributor

I updated a couple of links for fetch and added some stray files to clean. I'm also making a couple of suggestions regarding requiring PYVERSION in the command line and dropping the PREFIX from mpl_install. For this last one, I'm assuming that the dependencies are compile-time and matplotlib will work correctly from the relevant site-packages (I haven't seen any problems yet, although I've kept the dependencies in the PREFIX), but I welcome any comments or corrections.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fgb added 5 commits February 22, 2011 23:29
@fgb
Updated libpng's download link since old one was broken.
b06bf68
@fgb
Updated zlibs's download link even though url was still valid.
fa54ea9
@fgb
Fixed clean: changed libpng's extension to gz and added some stray fi…
a82c7dd 
…les from build process.
@fgb
Suggesting PYVERSION be input in the command line
ce1b43e 
Although a hard-coded PYVERSION=2.6 is safe for snow leopard, it might make more sense to leave it blank, defaulting to the 'python' command that takes precedence in the PATH. Also, suggesting in the documentation that it can be included in the command line might prompt users to choose the right version without having to edit the makefile.
@fgb
Removed the PREFIX from mpl_install in order to install into relevant…
1d7797c 
… site-packages.
jkseppan
jkseppan reviewed Feb 26, 2011
View reviewed changes
Comment thread README.osx Outdated

@jkseppan jkseppan Feb 26, 2011

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brackets that mean optional settings could be mistaken for syntax. I suggest reformulating this along these lines (note that you can set variables on the make command line):

make -f make.osx fetch deps mpl_install PREFIX=/Users/jdhunter/dev PYVERSION=2.6

Variables:
    PREFIX (required): where to install the dependencies
    PYVERSION (optional): <<<please describe the effect and the default>>>

The Python libraries will be installed in the usual location, not under PREFIX.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@fgb fgb Mar 1, 2011

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip. I was just following standard man notation, but I understand your concern and added a couple commits to address this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fgb added 2 commits February 28, 2011 16:45
@fgb
Improved README.osx as suggested by jkseppan.
b08acae
@fgb
Updated example usage, adding a README reference.
aac96d1
@jkseppan

jkseppan commented Mar 4, 2011

Copy link
Copy Markdown
Member

I would still like to get a comment from John Hunter on removing the --prefix argument.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan
Simplify make.osx, add targets
a71414d
@jkseppan

jkseppan commented Mar 6, 2011

Copy link
Copy Markdown
Member

Summary of changes in my commit:

  • export variables directly from make to avoid shell quoting issues; this includes a fix to ARCH_FLAGS
  • add check-prefix helper target to avoid accidentally compiling with -I/include/freetype2 etc
  • simplify mpl_build etc, add new targets for different ways of installing
  • add help as first target to avoid accidental make clean
  • document

I got "make binaries" almost working by disabling wxagg from the setup.cfg file and fudging some version numbers of the generated files. I don't think this review request broke anything there, it's just that my system doesn't have a good version of wxPython.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan

jkseppan commented Mar 6, 2011

Copy link
Copy Markdown
Member

This won't merge cleanly to master. I'll prepare another pull request for that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan

jkseppan commented Mar 26, 2011

Copy link
Copy Markdown
Member

In the absence of further comments, I'll merge this in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan
jkseppan merged commit a71414d into matplotlib:v1.0.x Mar 26, 2011
@richbwood richbwood mentioned this pull request Dec 19, 2012
test_pcolormesh hangs #1609
Closed
tacaswell pushed a commit that referenced this pull request Feb 18, 2016
@mdboom
Merge pull request #17 from tacaswell/image-interpolation
83f4bc9 
Image interpolation
efiring pushed a commit that referenced this pull request Sep 19, 2016
@tacaswell
Merge pull request #17 from phobson/doc_v2_rel_notes2
c4eb5e2 
DOC: explain changes to boxplot styles
fariza added a commit to fariza/matplotlib that referenced this pull request Sep 22, 2016
@fariza
Merge pull request matplotlib#17 from fariza/dr-log10
b354c11 
fixing log10 in Dr_db and moving pyplot import into method
swfiua pushed a commit to swfiua/matplotlib that referenced this pull request Mar 17, 2017
Zär'a Cardell
Merge pull request matplotlib#17 from swfiua/dice
ec97d73 
Dice
@WeatherGod WeatherGod mentioned this pull request Mar 2, 2018
pyplot hangs at plot() #10648
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@fgb @jkseppan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.