GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added figpager info by ebenp · Pull Request #18059 · matplotlib/matplotlib

Conversation

@ebenp

@ebenp ebenp commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

PR Summary

This is a Take #2 of adding a plotting template library called figpager to the third party documentation page in matplotlib. figpager is a plotting library using matplotlib for the subplots and adding in functionality of page size, margins and moving to the next page to create single and multipage documents using matplotlib's figure.

Under the previous draft pull request the framework of matplotlib was added to figpager's setup.py, the figpager header was corrected in index.rst, characters were wrapped at 79 and the example image was compressed using tinypng.com

I previously failed at squashing commits on the PR branch, deleted the repo to try and fix which broke the PR. This is a resubmitted branch with a single commit mirroring the closed PR, but less broken.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [x ] New features are documented, with examples if plot related
  • [ x] Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ebenp
Added figpager info
1b783f1
@ebenp ebenp mentioned this pull request Jul 25, 2020
add figpager as a third party package #18025
Closed
1 of 6 tasks
@ebenp

ebenp commented Jul 25, 2020

Copy link
Copy Markdown
Contributor Author

The closed PR is here: #18025

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

timhoffm
timhoffm approved these changes Jul 25, 2020
View reviewed changes
@timhoffm timhoffm added the Documentation label Jul 25, 2020
@timhoffm timhoffm added this to the v3.3-doc milestone Jul 25, 2020
@timhoffm
timhoffm marked this pull request as ready for review July 25, 2020 16:21
@timhoffm
timhoffm merged commit cca5b4d into matplotlib:master Jul 25, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 25, 2020
@timhoffm @meeseeksmachine
Backport PR matplotlib#18059: Added figpager info
435e86f
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 25, 2020
Backport PR #18059 on branch v3.3.0-doc (Added figpager info) #18065
Merged
@timhoffm

timhoffm commented Jul 25, 2020

Copy link
Copy Markdown
Member

Thanks for you contribution!

story645 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dstansby added a commit that referenced this pull request Jul 25, 2020
@dstansby
Merge pull request #18065 from meeseeksmachine/auto-backport-of-pr-18…
d8f61d8
…059-on-v3.3.0-doc

Backport PR #18059 on branch v3.3.0-doc (Added figpager info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

v3.3-doc

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ebenp @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.