GeezerVison

Thank you for this!

I think that there needs to be a bit of discussion if this is the way to go or not. The suggestion from @anntzer was to enable modifying all aspects of the arrow, where this was a special case. I can see that as a quite good option if we start modifying the arrow styles, although your approach clearly solves my use case.

Regarding documentation, the image is generated from "all" default styles during building. Hence, I think what should be done is to add a "What's new note" highlighting the new option. In addition, a test is required. I would simply add all three new styles in a single test image.

However, you may want to wait a bit with this until it is decided what the preferred way forward is.

Finally, one may want to modify the custom annotation demo on https://matplotlib.org/devdocs/tutorials/text/annotations.html to show some other shape, as the one in the example can now be obtained without a custom shape. (This should probably be done independent of solution, but not sure what a suitable alternative shape is...)

Thank you for this!

I think that there needs to be a bit of discussion if this is the way to go or not. The suggestion from @anntzer was to enable modifying all aspects of the arrow, where this was a special case. I can see that as a quite good option if we start modifying the arrow styles, although your approach clearly solves my use case.

Regarding documentation, the image is generated from "all" default styles during building. Hence, I think what should be done is to add a "What's new note" highlighting the new option. In addition, a test is required. I would simply add all three new styles in a single test image.

However, you may want to wait a bit with this until it is decided what the preferred way forward is.

Finally, one may want to modify the custom annotation demo on https://matplotlib.org/devdocs/tutorials/text/annotations.html to show some other shape, as the one in the example can now be obtained without a custom shape. (This should probably be done independent of solution, but not sure what a suitable alternative shape is...)

I made a change to the table in the tutorial section above the image. Should I not have done that -i.e. would that have also been generated automatically?

Also, where do I add a test?

I will work on a different version of this where the width of the arrowhead is adjustable as a percentage of the width of the body, and the length of the arrowhead is also adjustable by specifying an angle. Is this a better approach? And if so, how should I create a separate pull request for that?

Hello @Abitamim - I'm sorry this fell through the cracks. Are you interested in picking this back up?

For this PR, you probably want to add a test here: https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_patches.py

For the tutorial, I believe that is the right change.

Let us know if you have other questions and if you need help with the rebase that needs to be done here, check our documentation on rebasing on main. Cheers!

Closing in favor of #24744