GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bug Fix: Normalize kwargs for Histogram by TheSkyentist · Pull Request #29552 · matplotlib/matplotlib

Conversation

@TheSkyentist

@TheSkyentist TheSkyentist commented Jan 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR summary

Closes #28884 by normalizing kwargs for hist. The behavior of shortened options, such as ls and ec, now behave as expected.

pyplot.hist([1,2,3,4,5],bins=5,histtype='step',ls=':')
pyplot.savefig('test.pdf')

now produces test.pdf

First brought to my attention by @ecrohr

PR checklist

  • new and changed code is tested

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hirohira9119 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@TheSkyentist
Normalize kwargs for hist
40552c1
github-actions[bot]
github-actions Bot reviewed Jan 30, 2025
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@scottshambaugh

scottshambaugh commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

I believe this is the issue this would close? #28884
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TheSkyentist

TheSkyentist commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

Good catch! I made this draft while writing the issue. I’ll update the info.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TheSkyentist
Merge branch 'matplotlib:main' into hist-kwargs
4561ec9
@TheSkyentist
TheSkyentist marked this pull request as ready for review January 31, 2025 09:21
timhoffm
timhoffm approved these changes Feb 1, 2025
View reviewed changes
@QuLogic

QuLogic commented Feb 11, 2025

Copy link
Copy Markdown
Member

Does this fully close #28884? It doesn't add plurals, and I think we didn't yet make a decision in #28884 on whether we even wanted to add plurals.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@timhoffm

timhoffm commented Feb 11, 2025

Copy link
Copy Markdown
Member

You are right and that's ok. The issue itself is not decided whether we actually want plurals. This implements the obvious and uncontroversial part of the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
QuLogic
QuLogic reviewed Feb 11, 2025
View reviewed changes
Comment thread lib/matplotlib/axes/_axes.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@TheSkyentist @QuLogic
Avoid shadowing the builtin first!
6562e19 
Co-authored-by: Elliott Sales de Andrade <[email protected]>
QuLogic
QuLogic approved these changes Feb 14, 2025
View reviewed changes
@QuLogic QuLogic added this to the v3.11.0 milestone Feb 14, 2025
@QuLogic
QuLogic merged commit 067b77c into matplotlib:main Feb 14, 2025
@QuLogic

QuLogic commented Feb 14, 2025

Copy link
Copy Markdown
Member

Thanks @TheSkyentist! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.
TheSkyentist reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TheSkyentist
TheSkyentist deleted the hist-kwargs branch February 14, 2025 13:04
prafulgulani pushed a commit to prafulgulani/matplotlib that referenced this pull request Feb 22, 2025
@TheSkyentist @QuLogic @prafulgulani
Bug Fix: Normalize kwargs for Histogram (matplotlib#29552)
eeda778 
* Normalize kwargs for hist

* Avoid shadowing the builtin first!

Co-authored-by: Elliott Sales de Andrade <[email protected]>
@cgahr cgahr mentioned this pull request Mar 4, 2025
stroke is ignore daskol/mpl-typst#23
Closed
@hirohira9119 hirohira9119 mentioned this pull request Mar 26, 2025
[MNT]: Backport request for #29552 to 3.10.x #29812
Closed
@timhoffm

timhoffm commented Mar 26, 2025

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.10.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 26, 2025
@TheSkyentist @meeseeksmachine
Backport PR matplotlib#29552: Bug Fix: Normalize kwargs for Histogram
64ff907
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 26, 2025
Backport PR #29552 on branch v3.10.x (Bug Fix: Normalize kwargs for Histogram) #29814
Merged
@timhoffm timhoffm modified the milestones: v3.11.0, v3.10.2 Mar 26, 2025
QuLogic added a commit that referenced this pull request Mar 27, 2025
@QuLogic
Merge pull request #29814 from meeseeksmachine/auto-backport-of-pr-29…
f5d6737 
…552-on-v3.10.x

Backport PR #29552 on branch v3.10.x (Bug Fix: Normalize kwargs for Histogram)
@rcomer rcomer mentioned this pull request Apr 2, 2025
[Bug]: Unexpected behavior of the line style specifiers in the histogram method #29857
Closed
@rcomer rcomer mentioned this pull request Apr 28, 2025
[Bug]: Histogram ignores lw argument, no warning or error #29977
Closed
@ksunden ksunden mentioned this pull request May 9, 2025
merge up 3.10.3 #30031
Closed
5 tasks
@ksunden ksunden mentioned this pull request Jul 25, 2025
Manual Backport PR #30195 on branch v3.10.x (ci: Enable wheel builds on Python 3.14) #30356
Merged
5 tasks
@ksunden ksunden mentioned this pull request Aug 7, 2025
merge up v3.10.5 #30401
Merged
5 tasks
@richeshgupta richeshgupta mentioned this pull request Sep 23, 2026
SWR matplotlib__matplotlib-29552 razorpaytest/matplotlib#25
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@QuLogic QuLogic QuLogic approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.10.3

Development

Successfully merging this pull request may close these issues.

[ENH]: Expand hist() signature to support aliases and plural kwargs

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TheSkyentist @scottshambaugh @QuLogic @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.