GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — DOC: add color sequences reference example by rcomer · Pull Request #29563 · matplotlib/matplotlib Conversation
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I like the style.
I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.
You can add a sentence that users can register their own sequences as well and point to register. IMHO an example is not too helpful here. The concept "register -> you can query it by name" is straigt forward. The plot itself will not be helpful as you cannot visualize "there's a new element in the registry". That can only be inferred from the associated example code. But as said, the concept is so simple that any example is dilluting the message because of the additional visualization code.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
c2ae704 to
20d1900
Compare
|
Did there used to be a Dark1? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
20d1900 to
ae1359e
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Minor style suggestions.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Take or leave the suggestions.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
8f08300 to
c0cd916
Compare
…563-on-v3.10.x Backport PR #29563 on branch v3.10.x (DOC: add color sequences reference example)
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.