GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — DOC: add color sequences reference example by rcomer · Pull Request #29563 · matplotlib/matplotlib

Conversation

@rcomer

@rcomer rcomer commented Feb 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR summary

Introducing the Matplotlib Abacus!

image

I did not know that the color sequence registry was a thing. Once I did know, the next thing I wanted to know was what sequences are available. This PR adds an example showing all the built in sequences, analogous to the Colormaps reference and List of Named Colors.

I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

scottshambaugh reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@github-actions github-actions Bot added topic: color/color & colormaps Documentation: examples files in galleries/examples labels Feb 1, 2025
@rcomer

rcomer commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

New example

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

timhoffm
timhoffm reviewed Feb 1, 2025
View reviewed changes

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the style.

I am in two minds whether to add a second plot with a newly registered color sequence or to leave this as a purely reference example of what is available by default.

You can add a sentence that users can register their own sequences as well and point to register. IMHO an example is not too helpful here. The concept "register -> you can query it by name" is straigt forward. The plot itself will not be helpful as you cannot visualize "there's a new element in the registry". That can only be inferred from the associated example code. But as said, the concept is so simple that any example is dilluting the message because of the additional visualization code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rcomer reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread galleries/examples/color/color_sequences.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@rcomer
rcomer force-pushed the doc-color-sequences branch from c2ae704 to 20d1900 Compare February 1, 2025 17:55
@rcomer

rcomer commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

Did there used to be a Dark1?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rcomer
rcomer force-pushed the doc-color-sequences branch from 20d1900 to ae1359e Compare February 1, 2025 18:03
@rcomer

rcomer commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

Updated new example

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

timhoffm
timhoffm reviewed Feb 1, 2025
View reviewed changes

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread galleries/examples/color/color_sequences.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread galleries/examples/color/color_sequences.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread galleries/examples/color/color_sequences.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

timhoffm
timhoffm approved these changes Feb 1, 2025
View reviewed changes

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take or leave the suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rcomer
DOC: add color sequences reference example [ci doc]
c0cd916
@rcomer
rcomer force-pushed the doc-color-sequences branch from 8f08300 to c0cd916 Compare February 2, 2025 08:15
@timhoffm timhoffm added this to the v3.10.1 milestone Feb 2, 2025
@timhoffm
timhoffm merged commit dd8dbca into matplotlib:main Feb 2, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 2, 2025
@timhoffm @meeseeksmachine
Backport PR matplotlib#29563: DOC: add color sequences reference example
75b7bdf
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 2, 2025
Backport PR #29563 on branch v3.10.x (DOC: add color sequences reference example) #29564
Merged
@rcomer
rcomer deleted the doc-color-sequences branch February 2, 2025 16:51
timhoffm added a commit that referenced this pull request Feb 2, 2025
@timhoffm
Merge pull request #29564 from meeseeksmachine/auto-backport-of-pr-29…
74830c0
…563-on-v3.10.x

Backport PR #29563 on branch v3.10.x (DOC: add color sequences reference example)
@ksunden ksunden mentioned this pull request Mar 3, 2025
merge up v3.10.1 #29700
Merged
5 tasks
@timhoffm timhoffm mentioned this pull request Jul 17, 2025
Deprecate setting text kerning factor to any non-None value #30322
Merged
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Documentation: examples files in galleries/examples topic: color/color & colormaps

Projects

None yet

Milestone

v3.10.1

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rcomer @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.