GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix SubplotSpec.get_gridspec type hint by has2k1 · Pull Request #29724 · matplotlib/matplotlib

Conversation

@has2k1

@has2k1 has2k1 commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

PR summary

SubplotSpec.__init__ accepts an instance of GridSpecBase, the getter function should return a GridSpecBase as well.

PR checklist

  • [N/A] "closes #0000" is in the body of the PR description to link the related issue
  • [N/A] new and changed code is tested
  • [N/A] Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • [N/A] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@has2k1
Fix SubplotSpec.get_gridspec type hint
0dd3adb 
SubplotSpec.__init__ accepts an instance of GridSpecBase,
the getter function should return a GridSpecBase as well.
@github-actions github-actions Bot added the topic: geometry manager LayoutEngine, Constrained layout, Tight layout label Mar 10, 2025
@oscargus oscargus added the topic: typing label Mar 10, 2025
@oscargus oscargus added this to the v3.10.2 milestone Mar 10, 2025
oscargus
oscargus approved these changes Mar 10, 2025
View reviewed changes
timhoffm
timhoffm approved these changes Mar 10, 2025
View reviewed changes
@timhoffm
timhoffm merged commit 3cdbe7a into matplotlib:main Mar 10, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 10, 2025
@timhoffm @meeseeksmachine
Backport PR matplotlib#29724: Fix SubplotSpec.get_gridspec type hint
f098eb2
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 10, 2025
Backport PR #29724 on branch v3.10.x (Fix SubplotSpec.get_gridspec type hint) #29730
Merged
oscargus added a commit that referenced this pull request Mar 10, 2025
@oscargus
Merge pull request #29730 from meeseeksmachine/auto-backport-of-pr-29…
01d66d1 
…724-on-v3.10.x

Backport PR #29724 on branch v3.10.x (Fix SubplotSpec.get_gridspec type hint)
@ksunden ksunden mentioned this pull request May 9, 2025
merge up 3.10.3 #30031
Closed
5 tasks
@ksunden ksunden mentioned this pull request Jul 25, 2025
Manual Backport PR #30195 on branch v3.10.x (ci: Enable wheel builds on Python 3.14) #30356
Merged
5 tasks
@ksunden ksunden mentioned this pull request Aug 7, 2025
merge up v3.10.5 #30401
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes
@oscargus oscargus oscargus approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: geometry manager LayoutEngine, Constrained layout, Tight layout topic: typing

Projects

None yet

Milestone

v3.10.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@has2k1 @timhoffm @oscargus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.