GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Preparations for multivariate plotting by trygvrad · Pull Request #29877 · matplotlib/matplotlib Conversation
Contributor
PR summaryThis PR continues the work of #28658 and #28454 and #29876, aiming to close #14168. (Feature request: Bivariate colormapping) This is part two of the former PR, #29221, and builds upon #29876. Please see #29221 for the previous discussion #29876 includes:
This PR includes in this PR:
Features not included in this PR:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThis commit introduces the MultiNorm calss to prepare for the introduction of multivariate plotting methods
2 of 5 tasks
oscargus
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be good to get at least partial coverage for this branch.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't really been involved in this work nor understand how it works, but there is quite a bit of introduced code to deal with multiple datatypes? If this will be covered by tests/functionality in later PRs, that is fine, if not, please add tests for (most of) it.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
anntzer
reviewed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Error messages typically have no end dot (same comment applies throughout).
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, I'll need to change this in the other PR as well.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
anntzer
reviewed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do numpy masked arrays actually support struct arrays as mask, with possibly different masking of the fields?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have found that this is the only way numpy supports masking dtypes with multiple fields, but I will see if
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
anntzer
reviewed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could the dtype be e.g.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an interesting idea. I'll make a prototype and see if this would add unnecessary complexity somewhere else.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
anntzer
reviewed
Uh oh!
There was an error while loading. Please reload this page.
anntzer
reviewed
Uh oh!
There was an error while loading. Please reload this page.
trygvrad
force-pushed
the
multivariate-plot-prapare-2
branch
from
54a945c to
eeb895c
Compare
trygvrad
force-pushed
the
multivariate-plot-prapare-2
branch
from
41acef7 to
9c62126
Compare
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Merged
Thank you @QuLogic Co-authored-by: Elliott Sales de Andrade <[email protected]>
trygvrad
force-pushed
the
multivariate-plot-prapare-2
branch
from
9c62126 to
a276d89
Compare
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Feature request: Bivariate colormappingUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||||||||||||||||||||||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |