GeezerVison

Thank you for the feedback @anntzer !
Hopefully we can hear if @timhoffm has any thoughts on n_input / input_dims naming within the coming week.

See #29876 (comment)

Thank you @timhoffm
The PR should now be as we agreed (#29876 (comment)) :)

@QuLogic Thank you again and apologies for my tardiness (I was sick)
@timhoffm Do you think you could approve this PR now?

This is on hold until we sort out #30149 (Norm Protocol)
see #29876 (comment)

I changed vmin, vmax and clip to only accept iterables or None.

It dawned on me that it will be useful to allow None, with the behavior that it does not modify the vmin/vmax/clip on the constituent norms. This will be useful for use as a default, but also be useful for users that want to combine multiple norms into a MultiNorm without modifying the limits of the norms.

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

@timhoffm @anntzer I had made these changes, but actually committing them had slipped my mind. They are in now 😅

I'm on vacation now, so my schedule is a bit scrambled. @QuLogic I'll take a look at the rest of your comments soon :)

Sorry I dropped the ball on this. I can try to have a look but not before the middle of the month or so.

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

@QuLogic all the comments should have been addressed now, do you have the time to take another pass at it?

There are still a couple of comments that are unresolved/have no reply, at least.

@QuLogic @story645 thank you for your comments and patience on this, I believe i have addressed all the comments now, but please correct me again if there are some I have overlooked. Otherwise I look forward to your future comments :)

Just a minor last thing,

Thank you @QuLogic !

Were you expecting a squash merge?

Yes, I believe a squash merge would be most suitable

Thanks for working your way through this long process.