GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CI: Skip jobs on forks by oscargus · Pull Request #30118 · matplotlib/matplotlib

Conversation

@oscargus

@oscargus oscargus commented May 29, 2025

Copy link
Copy Markdown
Member

PR summary

Tests are skipped when pushing changes to a fork, but some other jobs are run. Especially Build CI wheels is a bit unnecessary to run on forks. Also, the CodeQL job is executed periodically on forks, which may lead to emails, but if nothing else waste of compute resources.

PR checklist

  • [N/A] "closes #0000" is in the body of the PR description to link the related issue
  • [N/A] new and changed code is tested
  • [N/A] Plotting related features are demonstrated in an example
  • [N/A] New Features and API Changes are noted with a directive and release note
  • [N/A] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@oscargus oscargus added CI: Run cibuildwheel Run wheel building tests on a PR CI: testing CI configuration and testing labels May 29, 2025
tacaswell
tacaswell approved these changes May 29, 2025
View reviewed changes
@tacaswell

tacaswell commented May 29, 2025

Copy link
Copy Markdown
Member

Only downside is that if you want to use CI to check wheel buliding you must open a PR or remove the check, but I think that is a reasonable trade off to avoid burning the commute on every push (there is a reason we only do it on PRs in an opt-in basis).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tacaswell tacaswell modified the milestones: v3.11.0, v3.10.4, v3.10-doc May 29, 2025
@tacaswell

tacaswell commented May 29, 2025

Copy link
Copy Markdown
Member

and we might as well backport this to all of our active branches.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

QuLogic
QuLogic reviewed May 30, 2025
View reviewed changes
Comment thread .github/workflows/cibuildwheel.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread .github/workflows/cibuildwheel.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@oscargus
CI: Skip jobs on forks
48a9d7c
@oscargus
oscargus force-pushed the forkci branch from 969e604 to 48a9d7c Compare May 30, 2025 06:42
@oscargus

oscargus commented May 30, 2025

Copy link
Copy Markdown
Member Author

you must open a PR or remove the check

Although that wasn't part of the plan, I think that one can push the branch to the matplotlib repo to get that. Since the people with push access are the same that are most likely to do that, I think it should be manageable (although a bit of behavior change as most seems to use their private forks. Personally, I always open a PR anyway as I had not thought about the alternative...).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oscargus

oscargus commented May 30, 2025

Copy link
Copy Markdown
Member Author

Btw, it seems like GitHub has disabled workflows on forks by default(?). Some recently cloned repos has a text that says that they are disabled. Makes sense.

GitHub Actions
Workflows aren’t being run on this forked repository
Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

Seems to have happened quite recently though.

(Or maybe there is some setting for the main repo? But it seems to correlate with when I forked them, at least a quick check says that.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@QuLogic QuLogic closed this Jun 4, 2025
@QuLogic QuLogic reopened this Jun 4, 2025
@QuLogic
QuLogic merged commit 5535df4 into matplotlib:main Jun 4, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 4, 2025
@QuLogic @meeseeksmachine
Backport PR matplotlib#30118: CI: Skip jobs on forks
9ca8dce
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 4, 2025
Backport PR #30118 on branch v3.10.x (CI: Skip jobs on forks) #30140
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 4, 2025
@QuLogic @meeseeksmachine
Backport PR matplotlib#30118: CI: Skip jobs on forks
e188484
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 4, 2025
Backport PR #30118 on branch v3.10.3-doc (CI: Skip jobs on forks) #30141
Merged
QuLogic added a commit that referenced this pull request Jun 4, 2025
@QuLogic
Merge pull request #30141 from meeseeksmachine/auto-backport-of-pr-30…
34cca89
…118-on-v3.10.3-doc

Backport PR #30118 on branch v3.10.3-doc (CI: Skip jobs on forks)
QuLogic added a commit that referenced this pull request Jun 5, 2025
@QuLogic
Merge pull request #30140 from meeseeksmachine/auto-backport-of-pr-30…
ff1f813
…118-on-v3.10.x

Backport PR #30118 on branch v3.10.x (CI: Skip jobs on forks)
@oscargus
oscargus deleted the forkci branch June 5, 2025 08:10
@ksunden ksunden mentioned this pull request Aug 7, 2025
merge up v3.10.5 #30401
Merged
5 tasks
@ksunden ksunden mentioned this pull request Aug 30, 2025
merge up v3.10.6 #30491
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic left review comments
@tacaswell tacaswell tacaswell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CI: Run cibuildwheel Run wheel building tests on a PR CI: testing CI configuration and testing

Projects

None yet

Milestone

v3.10-doc

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@oscargus @tacaswell @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.