GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: Enable wheel builds on Python 3.14 by QuLogic · Pull Request #30195 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Jun 20, 2025

Copy link
Copy Markdown
Member

PR summary

This should only end up on the nightly wheel upload for now.

Also, re-enable testing in places where Pillow wheels were previously missing, but are now available.

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic QuLogic added this to the v3.11.0 milestone Jun 20, 2025
@QuLogic QuLogic added the CI: Run cibuildwheel Run wheel building tests on a PR label Jun 20, 2025
@tacaswell

tacaswell commented Jun 20, 2025

Copy link
Copy Markdown
Member

I think we need #29393 merged first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic force-pushed the py314 branch 4 times, most recently from 5c87527 to 97187f5 Compare June 20, 2025 19:44
@QuLogic

QuLogic commented Jun 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I think we need #29393 merged first.

Yes, the wheels will probably not be useful until that is done.

Also, it appears that cibuildwheel (and most of our deps?) bumped to manylinux_2_28, so we can't test with manylinux2014 as target any more. It may be time to bump that for us as well. Pillow also doesn't seem to have macOS x86_64 wheels, but I'm not sure yet if that was intentional.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan

jkseppan commented Jun 21, 2025

Copy link
Copy Markdown
Member

See also #30204, which adds a test with Python 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jkseppan
jkseppan approved these changes Jun 21, 2025
View reviewed changes
@QuLogic QuLogic mentioned this pull request Jun 23, 2025
ci: Add Python 3.14-dev to the test matrix #30204
Closed
5 tasks
@QuLogic
QuLogic force-pushed the py314 branch from 97187f5 to 785da33 Compare June 26, 2025 03:17
@QuLogic

QuLogic commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Pillow also doesn't seem to have macOS x86_64 wheels, but I'm not sure yet if that was intentional.

That was not intentional, and they should have those wheels now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic
QuLogic force-pushed the py314 branch from 785da33 to ca92634 Compare June 26, 2025 03:23
@QuLogic
ci: Enable wheel builds on Python 3.14
257430e 
This should only end up on the nightly wheel upload for now.

Also, re-enable testing in places where Pillow wheels were previously
missing, but are now available.
@QuLogic
QuLogic force-pushed the py314 branch from ca92634 to 257430e Compare June 26, 2025 03:31
@neutrinoceros

neutrinoceros commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Hi, I'd like to plan ahead on adding support for Python 3.14 on a bunch of packages that depend on matplotlib. I don't mean to create a false sense of urgency; there is no actual rush that I know of, but may I ask if you guys anticipate this being merged soon ? Thanks !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic

QuLogic commented Jun 30, 2025

Copy link
Copy Markdown
Member Author

It needs a second approval.
neutrinoceros reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ianthomas23
ianthomas23 approved these changes Jul 1, 2025
View reviewed changes
@ianthomas23
ianthomas23 merged commit c805967 into matplotlib:main Jul 1, 2025
@QuLogic
QuLogic deleted the py314 branch July 1, 2025 07:29
@ksunden ksunden modified the milestones: v3.11.0, v3.10.4 Jul 24, 2025
@ksunden

ksunden commented Jul 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@meeseeksdev please backport to v3.10.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@ksunden

ksunden commented Jul 24, 2025

Copy link
Copy Markdown
Member

@meeseeksdev please backport to v3.10.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lumberbot-app

lumberbot-app Bot commented Jul 24, 2025

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c805967aac1f63f8ee3fd12dd5f1ae9eb7ae56ee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #30195: ci: Enable wheel builds on Python 3.14'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-30195-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR #30195 on branch v3.10.x (ci: Enable wheel builds on Python 3.14)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lumberbot-app lumberbot-app Bot added the Still Needs Manual Backport label Jul 24, 2025
ksunden pushed a commit to ksunden/matplotlib that referenced this pull request Jul 25, 2025
@ianthomas23 @ksunden
Backport PR matplotlib#30195: ci: Enable wheel builds on Python 3.14'
9973d47 
ci: Enable wheel builds on Python 3.14
(cherry picked from commit c805967)
@ksunden ksunden mentioned this pull request Jul 25, 2025
Manual Backport PR #30195 on branch v3.10.x (ci: Enable wheel builds on Python 3.14) #30356
Merged
5 tasks
tacaswell added a commit that referenced this pull request Jul 25, 2025
@tacaswell
Merge pull request #30356 from ksunden/auto-backport-of-pr-30195-on-v…
28273e1 
…3.10.x

Manual Backport PR #30195 on branch v3.10.x (ci: Enable wheel builds on Python 3.14)
@QuLogic QuLogic removed the Still Needs Manual Backport label Jul 25, 2025
@ksunden ksunden mentioned this pull request Aug 7, 2025
merge up v3.10.5 #30401
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkseppan jkseppan jkseppan approved these changes
@ianthomas23 ianthomas23 ianthomas23 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CI: Run cibuildwheel Run wheel building tests on a PR

Projects

None yet

Milestone

v3.10.5

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@QuLogic @tacaswell @jkseppan @neutrinoceros @ksunden @ianthomas23
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.