GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: Preload existing test images from text-overhaul-figures branch by QuLogic · Pull Request #30231 · matplotlib/matplotlib

Conversation

@QuLogic

@QuLogic QuLogic commented Jun 30, 2025

Copy link
Copy Markdown
Member

PR summary

This allows checking that there are no new failures, without committing the new figures to the repo until the branch is complete.

PR checklist

  • [n/a] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New Features and API Changes are noted with a directive and release note
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
oscargus and others added 30 commits April 16, 2025 19:28
@oscargus @QuLogic
Change first argument to add_axes from list to tuple
f797268
@oscargus @QuLogic
Change first argument to set_[xyz]lim to two arguments
db4e67c
@QuLogic
Ensure tuples are passed to Axes.set([xyz]lim=...)
edc8b20
@anntzer
Prepare to turn matplotlib.style into a plain module.
31d92dc
Having matplotlib.style be a package with the entire implementation in
matplotlib.style.core is a bit overkill, and also makes it slightly
awkward that USER_LIBRARY_PATHS is effectively a public API (clearly
intended as so, per the comment, even though we may do it differently
nowadays...) but only available in matplotlib.style.core, whereas
everything else is re-exported by matplotlib.style.

Prepare to flatten the implementation by deprecating
matplotlib.style.core and reexporting USER_LIBRARY_PATHS in
matplotlib.style.  Once the deprecation elapses, we'll be able to
move the implementation into a plain matplotlib/style.py module.
@QuLogic
Simplify RendererAgg::draw_markers buffers
f5851da
Instead of a fixed-size buffer, a dynamic buffer, and all the tracking
for them, just use a standard C++ container, which will clean up for
itself automatically.
@ayshih
Clean up image files that may be symbolic links to files
b154237
@ayshih
Clean up GIF image files from passing tests
8c75238
@scottshambaugh
Merge pull request matplotlib#30188 from ayshih/image_cleanup
5539d12
Fixed incomplete deletion of all images that have passed tests before upload
@scottshambaugh
Merge pull request matplotlib#30191 from QuLogic/simplify-marker
bebb263
Simplify RendererAgg::draw_markers buffers
@QuLogic
DOC: Remove last userdemo example
fc99473
Nested gridspecs are explained in
`galleries/examples/subplots_axes_and_figures/gridspec_nested.py`, and
layout is more generally explained in
`galleries/users_explain/axes/arranging_axes.py` and
`galleries/users_explain/axes/constrainedlayout_guide.py`

Closes matplotlib#25800
@timhoffm
Merge pull request matplotlib#30197 from QuLogic/no-userdemo
5a10e4d
DOC: Remove last userdemo example
@QuLogic
Replace facepair_t with std::optional
bbff84c
This type seems to cover the intent more clearly than `std::pair<bool,
...>`.
@anntzer
Use collections.deque to store animation cache data.
e77c17f
deques are exactly suited for the task at hand, and should be (here,
marginally) more efficient than repeatedly slicing off the start of the
list.

Also drop unneeded reference to old_frame_seq (the iterator already
keeps that data alive).
@QuLogic
Merge pull request matplotlib#28764 from oscargus/exampletesttyping
9340190
Fix argument types in examples and tests
@konmenel @timhoffm
Support individual styling of major and minor grid through rcParams (m…
6e51bec
…atplotlib#29481)

* Possible fix for issue matplotlib#13919

* fix flake warnings

* Resolve suggested changes

* Add new validators in stub file

* make stub file arguments same as runtime

* Add distinction for x and y axis in grid line options

* fix flake8

* Add What's New note

* Extend `_val_or_rc` to support multiply names
`_val_or_rc` now accept multiple rc names and return val or the first non-None value in rcParams. Returns last rc name if all other are None. Also, simplified code in `Tick` for grid lines creatation

* Fix linting for and _validate_linestyle_or_None to mypy allowlist

* Remove validate linestyle functions from stubtest allow list

* Revert change to just grid.major/minor distinction in rcParams

* Update What's New note and reduced example

* Add testing for `grid.major/minor.*` in rcParams

* fix indentation and linting

* Fix example description

* Fix spelling

* Fix type

* Fix formatting
Removed outer brackets

* `validate_color_or_None` private and fix argument names

* Fix validator name in stub file as well

* correct validators for grid.*.color keys

* Revert change in mypy-stubtest-allowlist.txt

---------

Co-authored-by: Tim Hoffmann <[email protected]>
@jkseppan
Merge pull request matplotlib#30206 from anntzer/ad
0dcd06f
Use collections.deque to store animation cache data.
@jkseppan
Merge pull request matplotlib#30163 from anntzer/ms
68c67c9
Prepare to turn matplotlib.style into a plain module.
@anntzer
Simplify dviFontInfo layout in backend pdf.
e3c7a64
- Use a simpler deterministic mapping of tex font names to pdf embedding
  names.
- Only resolve the required attributes when needed (in _embedTeXFont),
  which avoids e.g. having to carry around and worry about attributes
  with different names (e.g. "encoding" vs. "encodingfile").
@QuLogic
Merge pull request matplotlib#30082 from anntzer/simple-dvifontinfo
fed8c20
Simplify dviFontInfo layout in backend pdf.
@jkseppan @serhiy-storchaka
Implement Path.__deepcopy__ avoiding infinite recursion
c7edce3
To deep copy an object without calling deepcopy on the object itself,
create a new object of the correct class and iterate calling deepcopy on
its __dict__.

Closes matplotlib#29157 without relying on private CPython methods.
Does not fix the other issue with TransformNode.__copy__.

Co-authored-by: Serhiy Storchaka <[email protected]>
@jkseppan @QuLogic
Compare arrays with assert_array_equal
b20cf20
Co-authored-by: Elliott Sales de Andrade <[email protected]>
@jkseppan
Fix TransformNode.__copy__
5c7c915
without calling copy.copy
@ztw33
Update deprecations.rst
4ab1ab5
@ztw33
Update removals.rst
dd03655
@timhoffm
Merge pull request matplotlib#30212 from ztw33/main
58b6a06
[Doc]: fix bug in release notes for matplotlib v3.5.0 and v3.7.0
@anntzer
Fix label_outer in the presence of colorbars.
3ea5b63
The subgridspec to be considered should be the one containing both the
axes and the colorbar, not the sub-subgridspec of just the axes.
@tacaswell
Merge pull request matplotlib#30198 from jkseppan/path-deepcopy-via-m…
d05b43d
…etaclass

Implement Path.__deepcopy__ avoiding infinite recursion
@QuLogic
ci: Enable wheel builds on Python 3.14
257430e
This should only end up on the nightly wheel upload for now.

Also, re-enable testing in places where Pillow wheels were previously
missing, but are now available.
@chrisjbillington
Clean up Qt socket notifier to avoid spurious interrupt handler calls
b06d1f4
Closes matplotlib#29688

Objects without a parent are not necessarily cleaned up in `PyQt5/6`
when their reference count reaches zero, and must be explicitly cleaned
up with `deleteLater()`

This prevents the notifier firing after the signal handling was supposed
to have been reset to its previous state.

Rather than have both `bakend_bases._allow_interrupt()` and
`backend_qt._allow_interrupt_qt()` hold a reference to the notifier, we
pass it to  the backend-specific `handle_signint()` function for
cleanup.

Note the approach to cleaning up the notifier with `.deleteLater()`
followed by `sendPostedEvents()` is the documented workaround for when
immediate deletion is desired:

https://doc.qt.io/qt-6/qobject.html#deleteLater

This ensures the object is still deleted up even if the same event loop
does not run again.
@vagnermcj @timhoffm @QuLogic
Refactoring: Removing axis parameter from scales (matplotlib#29988)
c78c2f4
* Adding a decorator and Refactoring functions

* Fixing Ruff Errors

* Update scale.pyi

* Adding new line to the end of scale.pyi

* Update in docstring

* Fixing Handle Function

* Support optional axis in scales

Updated my refactor based on the feedbacks received

* Fixing ruff error

* change in parameters and in decorator

* parameter fix

* minor change in pyi

* Update lib/matplotlib/scale.py

Co-authored-by: Tim Hoffmann <[email protected]>

* Update lib/matplotlib/scale.py

Co-authored-by: Tim Hoffmann <[email protected]>

* Update lib/matplotlib/scale.py

Co-authored-by: Tim Hoffmann <[email protected]>

* Update lib/matplotlib/scale.pyi

Co-authored-by: Tim Hoffmann <[email protected]>

* Updating self and axis in pyi

* returning scale_factory to default

* Ruff checks

* description fix

* Update lib/matplotlib/scale.pyi

Co-authored-by: Tim Hoffmann <[email protected]>

* Undoing Unrelated Modifications

* fixing mypy tests

* Update lib/matplotlib/scale.pyi

Co-authored-by: Tim Hoffmann <[email protected]>

* keyword-argument suggestion

Co-authored-by: Elliott Sales de Andrade <[email protected]>

* kwargs pop before function call

Co-authored-by: Elliott Sales de Andrade <[email protected]>

---------

Co-authored-by: Tim Hoffmann <[email protected]>
Co-authored-by: Elliott Sales de Andrade <[email protected]>
@QuLogic
QuLogic force-pushed the preload-ci branch from 7fdd64a to 84250d1 Compare July 4, 2025 22:03
QuLogic and others added 11 commits July 4, 2025 18:12
@QuLogic
Check that stem input is 1D
7572823
This also has the side-effect of casting torch Tensors to NumPy arrays,
which fixes matplotlib#30216. Since `stem` is made up of `plot` and `[hv]lines`
whic already do this cast, this just moves it up one level which
prevents doing it twice.
@anntzer
Tweak docstrings of get_window_extent/get_tightbbox.
e78735b
Make the difference between the two methods clearer (only the latter
takes clipping into account).
@timhoffm
Merge pull request matplotlib#30262 from anntzer/gwegtb
cfc366b
Tweak docstrings of get_window_extent/get_tightbbox.
@timhoffm
Merge pull request matplotlib#30258 from QuLogic/ruff-update
faa3670
Clean up mypy & ruff config
@rcomer
DOC: fix artist see also sections
9c3f73b
@jklymak
Merge pull request matplotlib#30266 from rcomer/artist-seealso
90db4c1
@dstansby
Merge pull request matplotlib#30233 from QuLogic/stem-1d
947590d
Check that stem input is 1D
@dstansby
Fix figure legend when drawing stackplots
db6cf15
@dstansby
Add smoke test
b370e30
@timhoffm
Merge pull request matplotlib#30186 from dstansby/fig-legend-error
99b4ee3
Fix figure legend when drawing stackplots
@timhoffm
Merge pull request matplotlib#30235 from QuLogic/private-style
b6777b1
Don't expose private styles in style.available
@tacaswell

tacaswell commented Jul 7, 2025

Copy link
Copy Markdown
Member

Did you mean to pull main along with this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

QuLogic added 3 commits July 7, 2025 16:55
@QuLogic
Use old stride_windows implementation on 32-bit builds
f31ba35
This was originally for i686 on Fedora, but is now applicable to WASM,
which is 32-bit. The older implementation doesn't OOM.
@QuLogic
Merge pull request matplotlib#29115 from QuLogic/old-strides
4c345b4
Use old stride_windows implementation on 32-bit builds
@QuLogic
Merge branch 'main' into text-overhaul
a7fd524
@QuLogic
QuLogic force-pushed the preload-ci branch from 84250d1 to 1739a21 Compare July 7, 2025 23:07
@github-actions github-actions Bot added GUI: webagg topic: legend labels Jul 7, 2025
@QuLogic

QuLogic commented Jul 7, 2025

Copy link
Copy Markdown
Member Author

Yes, it was intentional, because #30239 fixes AppVeyor, and there should be no other conflicts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@QuLogic
ci: Preload existing test images from text-overhaul-figures branch
389373e
This allows checking that there are no _new_ failures, without
committing the new figures to the repo until the branch is complete.
@QuLogic
QuLogic force-pushed the preload-ci branch from 1739a21 to 389373e Compare July 7, 2025 23:37
@QuLogic
QuLogic merged commit 4d47644 into matplotlib:text-overhaul Jul 8, 2025
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Font and text overhaul Jul 8, 2025
@QuLogic
QuLogic deleted the preload-ci branch July 8, 2025 01:20
This was referenced Jul 8, 2025
ci: Fix image preload with multiple conflicts #30274
Merged
Add font feature API to Text #29695
Merged
Add language parameter to Text objects #29794
Merged
@QuLogic QuLogic mentioned this pull request Aug 23, 2025
Implement text shaping with libraqm #30000
Merged
3 of 5 tasks
wavebyrd pushed a commit to wavebyrd/matplotlib that referenced this pull request Mar 13, 2026
@QuLogic
Merge pull request matplotlib#30231 from QuLogic/preload-ci
be59d0f
ci: Preload existing test images from text-overhaul-figures branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkseppan jkseppan jkseppan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

backend: agg backend: pdf CI: Run cibuildwheel Run wheel building tests on a PR CI: testing CI configuration and testing Documentation: devdocs files in doc/devel Documentation: examples files in galleries/examples Documentation: tutorials files in galleries/tutorials GUI: MacOSX GUI: Qt GUI: tk GUI: webagg Maintenance topic: animation topic: axes topic: canvas and figure manager topic: color/color & colormaps topic: figures and subfigures topic: images topic: legend topic: mplot3d topic: path handling topic: polar topic: pyplot API topic: rcparams topic: styles topic: text/fonts topic: ticks axis labels topic: transforms and scales topic: widgets/UI

Projects

Font and text overhaul
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@QuLogic @tacaswell @jkseppan @oscargus @anntzer @ayshih @scottshambaugh @timhoffm @konmenel @ztw33 @chrisjbillington @vagnermcj @DWesl @ZPyrolink @neutrinoceros @trygvrad @rcomer @ianthomas23 @gameroman @cvanelteren
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.