GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — No need to sanitize extrema in Colorizer.set_clim by trygvrad · Pull Request #30470 · matplotlib/matplotlib

Conversation

@trygvrad

@trygvrad trygvrad commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

The @vmin.setter in Normalize (and its subclasses) call colors._sanitize_extrema(), so there is no reason to also do so in Colorizer.

This PR is intended to slightly clean the code before it is modified as the inclusion of MultiNorm #29876 and related PRs is propagated to the Colorizer in a future PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@trygvrad
no need to senitize extrama in colorizer
dee6cae 
the @vmin.setter in Normalize (and its subclasses) call _sanitize_extrema(), so there is no reason to also do so in colorizer
timhoffm
timhoffm approved these changes Aug 26, 2025
View reviewed changes
QuLogic
QuLogic approved these changes Aug 26, 2025
View reviewed changes
@QuLogic QuLogic added this to the v3.11.0 milestone Aug 26, 2025
@QuLogic
QuLogic merged commit 32e3018 into matplotlib:main Aug 26, 2025
@QuLogic QuLogic added this to Bivariate and Multivariate Colormapping Aug 26, 2025
@QuLogic QuLogic moved this to Done in Bivariate and Multivariate Colormapping Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

Bivariate and Multivariate Colormapping
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@trygvrad @QuLogic @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.