GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — FIX: Handle AxesWidget cleanup after failed init by larrybradley · Pull Request #30935 · matplotlib/matplotlib Conversation
Contributor
PR summaryIn 3.11.0.dev, This bug was introduced in #30591. Minimal example (also added as a regression test): import matplotlib.pyplot as plt from matplotlib.widgets import EllipseSelector fig, ax = plt.subplots() try: EllipseSelector(ax, foo="bar") except TypeError: pass plt.close(fig) PR checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
QuLogic
reviewed
Uh oh!
There was an error while loading. Please reload this page.
larrybradley
force-pushed
the
fix-axeswidget-del
branch
from
d65638e to
5bc69c9
Compare
timhoffm
reviewed
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
timhoffm
reviewed
Uh oh!
There was an error while loading. Please reload this page. Co-authored-by: Tim Hoffmann <[email protected]>
timhoffm
approved these changes
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
larrybradley
force-pushed
the
fix-axeswidget-del
branch
from
668304d to
eeb61a5
Compare
larrybradley
force-pushed
the
fix-axeswidget-del
branch
from
eeb61a5 to
b60db73
Compare
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
timhoffm
approved these changes
QuLogic
approved these changes
Uh oh!
There was an error while loading. Please reload this page.
llohse
pushed a commit
to llohse/matplotlib
that referenced
this pull request
* FIX: Handle AxesWidget cleanup after failed init * Apply code review suggestions * Update lib/matplotlib/tests/test_widgets.py Co-authored-by: Tim Hoffmann <[email protected]> * Remove __del__ method * Remove AxesWidget.__del__ from widgets.pyi --------- Co-authored-by: Tim Hoffmann <[email protected]>
llohse
pushed a commit
to llohse/matplotlib
that referenced
this pull request
* FIX: Handle AxesWidget cleanup after failed init * Apply code review suggestions * Update lib/matplotlib/tests/test_widgets.py Co-authored-by: Tim Hoffmann <[email protected]> * Remove __del__ method * Remove AxesWidget.__del__ from widgets.pyi --------- Co-authored-by: Tim Hoffmann <[email protected]>
llohse
pushed a commit
to llohse/matplotlib
that referenced
this pull request
* FIX: Handle AxesWidget cleanup after failed init * Apply code review suggestions * Update lib/matplotlib/tests/test_widgets.py Co-authored-by: Tim Hoffmann <[email protected]> * Remove __del__ method * Remove AxesWidget.__del__ from widgets.pyi --------- Co-authored-by: Tim Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |