GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — MNT: add `@classmethod` and remove `ignore` post #31867 by myzhang1029 · Pull Request #31884 · matplotlib/matplotlib

Conversation

@myzhang1029

@myzhang1029 myzhang1029 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
  • Why is this change necessary? MNT: Make get_default_filetype a classmethod #31867 now renders part of Add typing interface file and type hints for backends.backend_pdf #31854 obsolete
  • What problem does it solve? Missing @classmethod and unused type: ignore

PR checklist

  • [N/A] "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested ... via mypy and project test
  • [N/A] Plotting related features are demonstrated in an example
  • [N/A] New Features and API Changes are noted with a directive and release note
  • [N/A] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@myzhang1029
MNT: add @classmethod and remove ignore post matplotlib#31867
6af7e4c
timhoffm
timhoffm approved these changes Jun 12, 2026
View reviewed changes
@timhoffm timhoffm added this to the v3.11.1 milestone Jun 12, 2026
@timhoffm
timhoffm merged commit d421cec into matplotlib:main Jun 12, 2026
35 of 38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@timhoffm

timhoffm commented Jun 12, 2026

Copy link
Copy Markdown
Member

Thanks @myzhang1029
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lumberbot-app

lumberbot-app Bot commented Jun 12, 2026

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.11.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d421cec6b6212480bd172678b914647b2bc178a2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #31884: MNT: add `@classmethod` and remove `ignore` post #31867'
  1. Push to a named branch:
git push YOURFORK v3.11.x:auto-backport-of-pr-31884-on-v3.11.x
  1. Create a PR against branch v3.11.x, I would have named this PR:

"Backport PR #31884 on branch v3.11.x (MNT: add @classmethod and remove ignore post #31867)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lumberbot-app lumberbot-app Bot added the Still Needs Manual Backport label Jun 12, 2026
@myzhang1029
myzhang1029 deleted the types-31854-31867-followup branch June 12, 2026 23:07
@timhoffm

timhoffm commented Jun 13, 2026

Copy link
Copy Markdown
Member

I haven’t checked why The backport fails. Anyway, it’s not worth spending time on since this only fixes a comment.
myzhang1029 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic

QuLogic commented Jun 15, 2026

Copy link
Copy Markdown
Member

#31867 is in 3.12; there is no need to backport this PR.
myzhang1029 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic QuLogic removed the Still Needs Manual Backport label Jun 15, 2026
@QuLogic QuLogic modified the milestones: v3.11.1, v3.12.0 Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.12.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@myzhang1029 @timhoffm @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.