GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Cairo: Switch back to character codes for mathtext by QuLogic · Pull Request #32101 · matplotlib/matplotlib Conversation
Member
PR summarySince f630b48, the Cairo backend was switched to use glyph indices for mathtext, just as the Agg backend. Unfortunately, neither Pycairo nor cairocffi expose anything other than the toy font face API. This means the Cairo backend can only access fonts by family name and not explicit path. Apparently, the version of DejaVu Sans that we ship may differ from the system copy WRT glyph indices, so we need to switch back to character codes, which are standardized and won't cause the wrong glyph to be rendered accidentally. I can't really add a test, as in order to break, this requires a system-installed copy of DejaVu Sans of the right version that it has different glyph indices. Fixes #32084 AI DisclosureNone PR checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsSince f630b48, the Cairo backend was switched to use glyph indices for mathtext, just as the Agg backend. Unfortunately, neither Pycairo nor cairocffi expose anything other than the toy font face API. This means the Cairo backend can only access fonts by family name and not explicit path. Apparently, the version of DejaVu Sans that we ship may differ from the system copy WRT glyph indices, so we need to switch back to character codes, which are standardized and won't cause the wrong glyph to be rendered accidentally. Fixes matplotlib#32084
scottshambaugh
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My bundled / system dejavusans math glyphs indices are off by one, and I tested this locally as resolving it.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
QuLogic
pushed a commit
that referenced
this pull request
QuLogic
added a commit
that referenced
this pull request
…101-on-v3.11.x Backport PR #32101 on branch v3.11.x (Cairo: Switch back to character codes for mathtext)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsDevelopmentSuccessfully merging this pull request may close these issues. [Bug]: Exponential numbers on axis look like 10Σ² instead of 10⁻² with backend_gtk3cairoUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |