GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — TYP: PieContainer does not inherit from Container by rcomer · Pull Request #32344 · matplotlib/matplotlib

Conversation

@rcomer

@rcomer rcomer commented Sep 12, 2026

Copy link
Copy Markdown
Member

PR summary

I'm surprised stubtest didn't catch this. PieContainer did inherit from Container when #30733 was first opened, but we dropped that in review.

AI Disclosure

None used

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • [n/a] New and changed code is tested
  • [n/a] Plotting related features are demonstrated in an example
  • [n/a] New features and API changes have release notes
  • [n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rcomer

rcomer commented Sep 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Huh. stubtest passed locally but failed here. Do you have to clear something out to get a proper check?

Edit: maybe it was because I had not committed the change before the local check.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rcomer
rcomer marked this pull request as draft September 12, 2026 08:34
@rcomer
TYP: PieContainer does not inherit from Container
317465b
@rcomer
rcomer force-pushed the stub-pie branch from 90eec5c to 317465b Compare September 12, 2026 10:15
@rcomer
rcomer marked this pull request as ready for review September 12, 2026 10:23
timhoffm
timhoffm approved these changes Sep 12, 2026
View reviewed changes
@timhoffm timhoffm added this to the v3.11.3 milestone Sep 12, 2026
@timhoffm
timhoffm merged commit a99bc61 into matplotlib:main Sep 12, 2026
40 of 41 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@lumberbot-app

lumberbot-app Bot commented Sep 12, 2026

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:
They assume that the base project is the Git remote upstream and your fork is origin.

  1. Update backport branch.
git fetch upstream v3.11.x:v3.11.x
# or `git pull upstream v3.11.x` if you are on v3.11.x
  1. Create PR branch.
git switch -c auto-backport-of-pr-32344-on-v3.11.x v3.11.x
  1. Cherry pick the first parent branch of this PR on top of the older branch:
git cherry-pick -x -m1 a99bc61d82b76eab80509a57e39fa20a556d1985
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #32344: TYP: PieContainer does not inherit from Container'
  1. Push to a named branch:
git push --set-upstream origin auto-backport-of-pr-32344-on-v3.11.x
  1. Create a PR against branch v3.11.x, I would have named this PR:

Backport PR #32344 on branch v3.11.x (TYP: PieContainer does not inherit from Container)

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lumberbot-app lumberbot-app Bot added the Still Needs Manual Backport label Sep 12, 2026
@rcomer
rcomer deleted the stub-pie branch September 12, 2026 13:31
rcomer pushed a commit to rcomer/matplotlib that referenced this pull request Sep 12, 2026
@timhoffm @rcomer
Backport PR matplotlib#32344: TYP: PieContainer does not inherit from…
678e3e0
… Container

(cherry picked from commit a99bc61)
@rcomer rcomer mentioned this pull request Sep 12, 2026
Backport PR #32344: TYP: PieContainer does not inherit from Container #32347
Merged
5 tasks
@rcomer rcomer removed the Still Needs Manual Backport label Sep 12, 2026
timhoffm added a commit that referenced this pull request Sep 13, 2026
@timhoffm
Merge pull request #32347 from rcomer/stub-pie-backport
7fe341c
Backport PR #32344: TYP: PieContainer does not inherit from Container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.11.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rcomer @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.