GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fixing osx makefile by fgb · Pull Request #4 · matplotlib/matplotlib

Conversation

fgb commented Feb 20, 2011

Copy link

Copy Markdown

Contributor

I updated a couple of links for fetch and added some stray files to clean. I'm also making a couple of suggestions regarding requiring PYVERSION in the command line and dropping the PREFIX from mpl_install. For this last one, I'm assuming that the dependencies are compile-time and matplotlib will work correctly from the relevant site-packages (I haven't seen any problems yet, although I've kept the dependencies in the PREFIX), but I welcome any comments or corrections.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

fgb added 6 commits

February 20, 2011 00:19


          Updated libpng's sourceforge download link since old one was broken.

a9f708b


          Fixed clean, by changing libpng to be a gz instead of bz2.

9560e0e


          Probably a superfluous change, since the zlib url still worked, but w…

e4b38b6

…asn't up to date.


          Suggesting PYVERSION be input on the command line

c658a84

Although a hard-coded PYVERSION=2.6 is safe for snow leopard, it might make more sense to leave it blank, defaulting to the 'python' command that takes precedence in the PATH. On the other hand, suggesting in the documentation that it can be included to the command line might prompt users to choose the right version without editing the makefile.


          Removed the PREFIX from mpl_install in order to install into relevant…

27a2b23

… site-packages.


          Added some stray files from build process to clean.

7b47d25

ddale commented Feb 22, 2011

Copy link

Copy Markdown

Contributor

Please modify the request to pull these into v1.0.x instead of master.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fgb commented Feb 22, 2011

Copy link

Copy Markdown

Contributor Author

My bad, I was following the comments on the other pull requests and realized that this was how you guys were proceeding. I'll take care of this later tonight. Why exactly is it better to pull to tags instead of to the master? I guess I still have some baggage from SVN that is confusing me a bit.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ddale commented Feb 22, 2011

Copy link

Copy Markdown

Contributor

Pull to tags? I don't understand. If you apply your changes relative to the v1.0.x branch, and request those changes be pulled into the v1.0.x branch, from there we can simply merge the v1.0.x branch into master so both branches benefit from the changes. We can't merge from master into v1.0.x.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fgb commented Feb 22, 2011

Copy link

Copy Markdown

Contributor Author

Oops, sorry. I thought v1.0.x was a tag instead of a branch. I'll get this done soon. Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

scottza and others added 9 commits

February 23, 2011 14:58


          BUG: Get autofmt_xdate to work when used with twinx

1ab26de

* See mailing list discussion at
  http://sourceforge.net/mailarchive/message.php?msg_id=26618642


          BUG: Don't alter current behaviour of autofmt_xdate

b86140c

* Make sure that autofmt_xdate does the right thing when the figure
  contains a single Axes object that is not be derived from
  matplotlib.axes.SubplotBase.


          REV: Attend to code review comments

125c332

* See https://github.com/matplotlib/matplotlib/issues#issue/1


          BUG: Incorrect indentation for adjust_subplots

411b153


          Allow setting of default histogram type from matplotlibrc

36708db

This change doesn't yet include documentation updates


          clabel accepts callable as fmt kwarg; modified patch by Daniel Hyams

ff4a592


          colors.rgb_to_hsv: don't divide by zero

5cd634e


          add .gitattributes and .gitignore, fix CRLF

d4cea82


          update examples to use sample_data from github

ad96aec

richbwood mentioned this pull request

Dec 19, 2012

test_pcolormesh hangs #1609

Closed

tacaswell referenced this pull request in tacaswell/matplotlib

Oct 27, 2013


          Merge pull request #4 from tacaswell/stylesheets

8471cc7

pep8

bbolker mentioned this pull request

Mar 11, 2015

segfault: fill_between with Python3 #4210

Closed

tacaswell pushed a commit that referenced this pull request

Sep 13, 2015


          Merge pull request #4 from tacaswell/unpack_labeled_data_alternative

572c1e2

MNT: use IPython's signature if needed + available

VincentVandalon mentioned this pull request

Mar 1, 2016

Offset and scaling factors in axis format #4376 #6086

Closed

watkinrt mentioned this pull request

Feb 7, 2017

Feature request: mathtext support for \displaystyle #1888

Closed

swfiua pushed a commit to swfiua/matplotlib that referenced this pull request

Mar 17, 2017


          Merge pull request matplotlib#4 from swfiua/master

d3c6134

Hacking around trying to get Curio monitor working in currie

QuLogic referenced this pull request in QuLogic/matplotlib

Sep 27, 2017


          Always NUL-terminate TrueType font table buffer.

ac0cb47

This fixes some possible heap buffer overflows, such as the following
triggered by our cmmi10.ttf:

```
ERROR: AddressSanitizer: heap-buffer-overflow on address 0x617000235709 at pc 0x7f95efd3c48a bp 0x7ffe41b6ecc0 sp 0x7ffe41b6ecb0
READ of size 1 at 0x617000235709 thread T0
    #0 0x7f95efd3c489 in utf16be_to_ascii extern/ttconv/pprdrv_tt.cpp:178
    #1 0x7f95efd3c489 in Read_name(TTFONT*) extern/ttconv/pprdrv_tt.cpp:339
    #2 0x7f95efd499ef in read_font(...) extern/ttconv/pprdrv_tt.cpp:1325
    #3 0x7f95efd4c602 in get_pdf_charprocs(...) extern/ttconv/pprdrv_tt.cpp:1420
    #4 0x7f95efd35c22 in py_get_pdf_charprocs src/_ttconv.cpp:217

0x617000235709 is located 1 bytes to the right of 648-byte region [0x617000235480,0x617000235708)
allocated by thread T0 here:
    #0 0x7f9612262a38 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xdea38)
    #1 0x7f95efd3b261 in GetTable(TTFONT*, char const*) extern/ttconv/pprdrv_tt.cpp:140
```

QuLogic referenced this pull request in QuLogic/matplotlib

Sep 27, 2017


          Always NUL-terminate TrueType font table buffer.

This fixes some possible heap buffer overflows, such as the following
triggered by our cmmi10.ttf:

```
ERROR: AddressSanitizer: heap-buffer-overflow on address 0x617000235709 at pc 0x7f95efd3c48a bp 0x7ffe41b6ecc0 sp 0x7ffe41b6ecb0
READ of size 1 at 0x617000235709 thread T0
    #0 0x7f95efd3c489 in utf16be_to_ascii extern/ttconv/pprdrv_tt.cpp:178
    #1 0x7f95efd3c489 in Read_name(TTFONT*) extern/ttconv/pprdrv_tt.cpp:339
    #2 0x7f95efd499ef in read_font(...) extern/ttconv/pprdrv_tt.cpp:1325
    #3 0x7f95efd4c602 in get_pdf_charprocs(...) extern/ttconv/pprdrv_tt.cpp:1420
    #4 0x7f95efd35c22 in py_get_pdf_charprocs src/_ttconv.cpp:217

0x617000235709 is located 1 bytes to the right of 648-byte region [0x617000235480,0x617000235708)
allocated by thread T0 here:
    #0 0x7f9612262a38 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xdea38)
    #1 0x7f95efd3b261 in GetTable(TTFONT*, char const*) extern/ttconv/pprdrv_tt.cpp:140
```

WeatherGod mentioned this pull request

Mar 2, 2018

pyplot hangs at plot() #10648

Closed

timhoffm pushed a commit that referenced this pull request

Mar 30, 2019


          Merge pull request #4 from matplotlib/master

2573f51

update fork

matt256 added a commit to matt256/matplotlib that referenced this pull request

Dec 15, 2022


          # This is a combination of 4 commits.

818c0fd

# This is the 1st commit message:

bug fix inserted

# This is the commit message matplotlib#2:

issue test runs but fails comparison

# This is the commit message matplotlib#3:

updated styling in test image

# This is the commit message matplotlib#4:

bug fix inserted

jklymak pushed a commit that referenced this pull request

Mar 28, 2023


          fix: make tests slightly error tolerant (#4)

503356e

uses the assert_almost_equal function instead of assert_array_equal

Higgs32584 pushed a commit to Higgs32584/matplotlib that referenced this pull request

Apr 17, 2023


          fix: make tests slightly error tolerant (matplotlib#4)

637e225

uses the assert_almost_equal function instead of assert_array_equal

john-odonovan mentioned this pull request

May 5, 2023

[Bug]: Coredump when importing matplotlib.pyplot #25823

Closed

story645 mentioned this pull request

Apr 15, 2026

[Doc]: Define: User Guide > Plotting data #31496

Open

This pull request was closed.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.