GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Marker/scatter reconciliation by mdboom · Pull Request #400 · matplotlib/matplotlib

Conversation

@mdboom

@mdboom mdboom commented Jul 15, 2011

Copy link
Copy Markdown
Member

The set of available Line2D markers and scatter markers has always been slightly different. Some features (such as mathtext markers) were only available in one place and not the other. This refactors everything into a new markers.py module which is used from everywhere else to keep the functionality consistent and equally capable everywhere.

This seems to pass all regression tests and doesn't change any relevant examples, but it's pretty core functionality, so care should be taken it doesn't break anything.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mdboom added 5 commits July 14, 2011 15:45
@mdboom
First step in marker refactoring. Create new marker class and reimple…
b93fc8f 
…ment Line2D-based markers in terms of it.
@mdboom
Update Gtk and Qt4 backends to be aware of the new location of the ma…
85b5e28 
…rker definitions.
@mdboom
Make scatter use the new marker class. Add a "scatter_symbol" example…
6fe5fa0 
…. Make legend support the new kind of scatter.
@mdboom
Implement fill style for octagon marker.
83da58e
@mdboom
Fix docstrings about refactored markers.
243d78d
@mdboom

mdboom commented Jul 15, 2011

Copy link
Copy Markdown
Member Author

Addresses bugs #350, #125
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mdboom added 3 commits July 15, 2011 16:21
@mdboom
Clarify CHANGELOG comment.
00b029e
@mdboom
No need to square just to take the square root.
85d3ea9
@mdboom
Fix some regression tests.
af7ac12
efiring
efiring reviewed Jul 18, 2011
View reviewed changes
Comment thread CHANGELOG Outdated

@efiring efiring Jul 18, 2011

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2011

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdboom
Fix typo in CHANGELOG and add attribution.
c9e0ebc
mdboom added a commit that referenced this pull request Jul 25, 2011
@mdboom
Merge pull request #400 from mdboom/marker_scatter_reconcile
fafc0cf 
Marker/scatter reconciliation
@mdboom
mdboom merged commit fafc0cf into matplotlib:master Jul 25, 2011
@mdboom
mdboom deleted the marker_scatter_reconcile branch March 3, 2015 18:44
@QuLogic QuLogic added this to the v1.1.0 milestone Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mdboom @efiring @pelson @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.