GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — FIX: resizing a figure in webagg by eyurtsev · Pull Request #4035 · matplotlib/matplotlib

Conversation

@eyurtsev

@eyurtsev eyurtsev commented Jan 24, 2015

Copy link
Copy Markdown
Contributor

Resizing in webagg doesn't work because the figure grabs mouse events (#3338).

This is an iteration over a previous pull request (#3341), including the minimal changes required to fix the problem.

I don't think that the debouncing is necessary anymore, so I removed it. I tested this with both a static plot and animations.

This addresses 90% of the problem.

Resizing issues will reappear if working with multiple figures on the same page.
Refactoring would be necessary probably to introduce some "resizing manager" that will prevent mouse events from being passed to all figures while any figure is being resized.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tacaswell tacaswell added the status: needs review label Jan 24, 2015
@blink1073

blink1073 commented Jan 25, 2015

Copy link
Copy Markdown
Member

Tested, LGTM, 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blink1073
blink1073 reviewed Jan 25, 2015
View reviewed changes
Comment thread lib/matplotlib/backends/web_backend/mpl.js Outdated

@blink1073 blink1073 Jan 25, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: we haven't been using braces if there is only one statement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eyurtsev

eyurtsev commented Jan 25, 2015

Copy link
Copy Markdown
Contributor Author

@blink1073 how do I submit a revision to the code?

If I remove the brackets and push the new code to my fork on github will the pull request here get automatically synhronized?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blink1073

blink1073 commented Jan 25, 2015

Copy link
Copy Markdown
Member

Yes, you can keep pushing changes to your fix_webagg_resize_02 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell mentioned this pull request Jan 25, 2015
fix for figure resizing in webagg #3341
Closed
@eyurtsev

eyurtsev commented Jan 26, 2015

Copy link
Copy Markdown
Contributor Author

Curly braces have been terminated.

But an accidental commit was added!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eugene Yurtsev
FIX: resizing a figure in webagg
0a245ac
@eyurtsev
eyurtsev force-pushed the fix_webagg_resize_02 branch from 088bedb to 0a245ac Compare January 26, 2015 00:44
@eyurtsev

eyurtsev commented Jan 26, 2015

Copy link
Copy Markdown
Contributor Author

Well, just did my first rebase. And forced a push into github repository. There should be only a single commit. :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blink1073

blink1073 commented Jan 26, 2015

Copy link
Copy Markdown
Member

Looks good @eyurtsev. You didn't necessarily have to rebase for just one extra commit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell added this to the v1.4.3 milestone Jan 26, 2015
@pelson

pelson commented Jan 26, 2015

Copy link
Copy Markdown
Member

👍 LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tacaswell added a commit that referenced this pull request Jan 26, 2015
@tacaswell
Merge pull request #4035 from eyurtsev/fix_webagg_resize_02
61fd742 
FIX : resizing a figure in webagg
@tacaswell
tacaswell merged commit 61fd742 into matplotlib:master Jan 26, 2015
@tacaswell tacaswell removed the status: needs review label Jan 26, 2015
@tacaswell

tacaswell commented Jan 26, 2015

Copy link
Copy Markdown
Member

also, improved functionality with a net removal of code!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tacaswell added a commit that referenced this pull request Jan 26, 2015
@tacaswell
Merge pull request #4035 from eyurtsev/fix_webagg_resize_02
7468be2 
FIX : resizing a figure in webagg
@tacaswell

tacaswell commented Jan 26, 2015

Copy link
Copy Markdown
Member

back ported as 7468be2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eyurtsev

eyurtsev commented Jan 27, 2015

Copy link
Copy Markdown
Contributor Author

@blink1073 it was time to learn :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eyurtsev
eyurtsev deleted the fix_webagg_resize_02 branch January 28, 2015 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@eyurtsev @blink1073 @pelson @tacaswell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.