GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes bug 3165422: color cycles even if kwarg 'color' is set by faucon · Pull Request #41 · matplotlib/matplotlib

Conversation

@faucon

@faucon faucon commented Mar 10, 2011

Copy link
Copy Markdown
Contributor

Hi there,
i send a patch to matplotlib-devel last week. As there was no reaction, i now send it again as an pull request.

-maximilian

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@faucon
fixes bug 3165422: color cycles even if kwarg 'color' is set
531b7cc
@efiring

efiring commented Mar 10, 2011

Copy link
Copy Markdown
Member

Looks reasonable to me. One might raise the question of whether markerfacecolor etc kwargs should be checked along with the color kwarg. The problem with doing that, though, is that someone might want to specify markeredgecolor with a kwarg, while letting marker face colors cycle. That suggests that restricting the check to the "color" kwarg is OK.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WeatherGod

WeatherGod commented Mar 10, 2011

Copy link
Copy Markdown
Member

I think this patch is reasonable. And I agree that this should only be focused on 'color'. If we want to cycle markeredgecolor, we can address that separately.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efiring

efiring commented Mar 10, 2011

Copy link
Copy Markdown
Member

It is not a question of wanting to cycle markeredgecolor, but rather of detecting when a user doesn't want the cycle to be advanced. Still, at this point, going with the patch seems reasonable. I don't have time for it right now; if you do, go ahead and merge it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efiring
efiring merged commit 531b7cc into matplotlib:master Mar 23, 2011
@richbwood richbwood mentioned this pull request Dec 19, 2012
test_pcolormesh hangs #1609
Closed
magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013
@francisco-dlp
fixes matplotlib#41 and some few enhancements to the pil io plugin
0e0e5e5 
BUG-FIX: fixes matplotlib#41 by using mahotas if available
ENHANCE: new parameter only_view to save only the current view
ENHANCE: before proceeding to rescale it first check if it makes sense
fariza added a commit to fariza/matplotlib that referenced this pull request Sep 22, 2016
@fariza
Merge pull request matplotlib#41 from fariza/invert_vertical_profile
95cb379 
vertical profile inverted
@WeatherGod WeatherGod mentioned this pull request Mar 2, 2018
pyplot hangs at plot() #10648
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@faucon @efiring @WeatherGod
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.