GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix 3187521 - crash due to unescaped fontpaths by ivanov · Pull Request #59 · matplotlib/matplotlib

Conversation

@ivanov

@ivanov ivanov commented Mar 26, 2011

Copy link
Copy Markdown
Member

Some paths were improperly being interpreted as a regular expression, leading to errors.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ivanov
fixes 3187521 - crash due to unescaped fontpaths
3f1bc79
@jkseppan

jkseppan commented Mar 26, 2011

Copy link
Copy Markdown
Member

I don't see how calling repr fixes this - it'll just put some quotation marks around the directory name, right? The glob function used here doesn't call any Unix functions, it calls fnmatch which compiles the pattern to a regexp. What we need to do is call os.listdir on each directory and filter the results with fnmatch.filter("*.ttf") etc.

Or am I getting this wrong?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan

jkseppan commented Mar 26, 2011

Copy link
Copy Markdown
Member

See pull request #60
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdboom

mdboom commented Mar 28, 2011

Copy link
Copy Markdown
Member

Chose alternative in pull request #60 -- therefore closing this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdboom mdboom closed this Mar 28, 2011
@richbwood richbwood mentioned this pull request Dec 19, 2012
test_pcolormesh hangs #1609
Closed
magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013
@francisco-dlp
BUG-FIX: fixes matplotlib#59
924052a
@jkseppan jkseppan mentioned this pull request Jul 16, 2014
Simplify and unify font finding #60
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ivanov @jkseppan @mdboom
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.