GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make @cleanup *really* support generative tests. by anntzer · Pull Request #6022 · matplotlib/matplotlib

Conversation

@anntzer

@anntzer anntzer commented Feb 18, 2016

Copy link
Copy Markdown
Contributor

Generative tests were still not run after #5809. If f is defined as def f(): yield, isgeneratorfunction(f) == isgenerator(f()) == True.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anntzer
Make @cleanup *really* support generative tests.
56ec0c6
@mdboom mdboom added the status: needs review label Feb 18, 2016
@tacaswell tacaswell closed this Feb 18, 2016
@tacaswell tacaswell reopened this Feb 18, 2016
@tacaswell tacaswell added status: needs review and removed status: needs review labels Feb 18, 2016
@tacaswell

tacaswell commented Feb 18, 2016

Copy link
Copy Markdown
Member

'power cycled' to re-trigger build against new master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell added this to the 2.1 (next point release) milestone Feb 18, 2016
@anntzer anntzer mentioned this pull request Feb 18, 2016
Better choice of offset-text. #5785
Merged
tacaswell added a commit that referenced this pull request Feb 18, 2016
@tacaswell
Merge pull request #6022 from anntzer/cleanup-generative-tests-again
236411c 
Make @cleanup *really* support generative tests.
@tacaswell
tacaswell merged commit 236411c into matplotlib:master Feb 18, 2016
@tacaswell

tacaswell commented Feb 18, 2016

Copy link
Copy Markdown
Member

Merging as I do not think the close/open cycle restarts appveyor.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell tacaswell removed the status: needs review label Feb 18, 2016
@tacaswell

tacaswell commented Feb 18, 2016

Copy link
Copy Markdown
Member

Does this need to be backported to 2.x?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic

QuLogic commented Feb 18, 2016

Copy link
Copy Markdown
Member

#5809 is actually milestoned to be on 1.5.2, though I'm not seeing it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
anntzer deleted the cleanup-generative-tests-again branch February 21, 2016 17:32
@QuLogic

QuLogic commented Mar 26, 2016

Copy link
Copy Markdown
Member

This should be backported if we want to get #5785 into 2.x, no?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tacaswell added a commit that referenced this pull request Mar 26, 2016
@tacaswell
Merge pull request #6022 from anntzer/cleanup-generative-tests-again
80be853 
Make @cleanup *really* support generative tests.
@tacaswell tacaswell modified the milestones: 2.0 (style change major release), 2.1 (next point release) Mar 26, 2016
@tacaswell

tacaswell commented Mar 26, 2016

Copy link
Copy Markdown
Member

backported to v2.x as 0375ea4

@QuLogic Good catch on this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bearstrong pushed a commit to bearstrong/matplotlib that referenced this pull request Apr 1, 2016
@tacaswell @bearstrong
Merge pull request matplotlib#6022 from anntzer/cleanup-generative-te…
bdaefb9 
…sts-again

Make @cleanup *really* support generative tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@anntzer @tacaswell @QuLogic @mdboom
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.