GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bugfix: enable picking of AsteriskCollection instances by efiring · Pull Request #72 · matplotlib/matplotlib

Conversation

@efiring

@efiring efiring commented Apr 4, 2011

Copy link
Copy Markdown
Member

A primary use of these is in scatter, where they provide + and x
symbols.

This fixes the problem reported here:
http://article.gmane.org/gmane.comp.python.matplotlib.devel/10069

The present commit is a fairly minimal solution to the problem; it makes the symbols pickable without breaking anything that I know of. It does change default behavior in that filled symbols from scatter (i.e., collections) now obey the pickradius--the cursor can be outside the symbol if self._pickradius or self._picker is non-zero. This could be addressed by setting different default _pickradius falues for different types of symbol; the filled types could default to zero, or at least to a smaller value than the default for unfilled types, and this can then be overridden by the picker kwarg if the user so chooses. I would be willing to add this change to the present branch, if others think it a good idea; I am neutral on doing it here and now.

Note that all this leaves an inconsistency between collections and Line2D objects. In the former, picking is based on the object path after stroking with a line of pickradius thickness; in the latter picking is based on datapoint locations and pickradius alone, with no account taken of the marker size. If any of this is to be smoothed out, I am inclined to do it in master, not v1.0.x.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@efiring
Bugfix: enable picking of AsteriskCollection instances
9eb10ef
A primary use of these is in scatter, where they provide + and x
symbols.
mdboom
mdboom reviewed Apr 4, 2011
View reviewed changes
Comment thread lib/matplotlib/collections.py

@mdboom mdboom Apr 4, 2011

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticing that this, Line and Axis all have a pickradius, maybe it belongs in Artist? Doesn't necessarily have to be done for this pull, but it seems like a useful refactoring to make.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@efiring
efiring merged commit 9eb10ef into matplotlib:v1.0.x Apr 13, 2011
@richbwood richbwood mentioned this pull request Dec 19, 2012
test_pcolormesh hangs #1609
Closed
magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013
@francisco-dlp
Merge pull request matplotlib#72 from pburdet/ENH_spectrum_3D_dimension
46fc68a
Fixes matplotlib#70. EHN: to_image and to_ spectrum modified.
fariza added a commit to fariza/matplotlib that referenced this pull request Sep 22, 2016
@fariza
Merge pull request matplotlib#72 from fgoudreault/cam_documentation
9298766
camera and camera routines doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@efiring @mdboom
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.