GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updated setupext.py that allows building on Mac OS X by r-owen · Pull Request #965 · matplotlib/matplotlib

Conversation

@r-owen

@r-owen r-owen commented Jun 26, 2012

Copy link
Copy Markdown
Contributor

Fix build on Mac OS X so that:

  • It "just builds" against Apple's Python using Apple's library, with no special configuration required.
  • It also looks in /usr/local. This should support HomeBrew and is used on all other platforms, so I think most users expect it.

This new setupext.py will not work with MacPorts or fink, but the old one would not either. I think it is dangerous to try to support both by default, since old or incomplete setups could lead to including unexpected libraries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
r-owen added 2 commits March 1, 2012 14:12
@r-owen
Change setupext.py to be compatible with Mac OS X (darwin);
474abc8
include instructions for users of packaging systems (e.g. MacPorts).
@r-owen
Minor cleanup
17a82f9
@r-owen r-owen mentioned this pull request Jun 26, 2012
setupext.py incorrect for Mac OS X #168
Closed
@pelson

pelson commented Jun 27, 2012

Copy link
Copy Markdown
Member

+1 from me. The discussion on #168 is the relevant background information.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jswhit

jswhit commented Jun 27, 2012

Copy link
Copy Markdown

Not having it look for fink and macports packages is fine - if you have one of those you can just use their matplotlib packages.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pelson

pelson commented Jun 28, 2012

Copy link
Copy Markdown
Member

@jdh2358: I have been able to test this successfully on OSX 10.7 with both homebrew and apple Python 2.7. @r-owen has tested on 10.6. Do you know who else should see this before I commit?

@efiring: I know you were involved in the original discussion. Do you have any objections to this change?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@efiring

efiring commented Jun 28, 2012

Copy link
Copy Markdown
Member

No objection. Let's try it and see what happens.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jkseppan

jkseppan commented Jun 29, 2012

Copy link
Copy Markdown
Member

+1 (though cannot test now, travelling)

I think the big reason for recommending make.osx is all the build problems you get when setupext picks up incompatible versions of libraries, so reducing the number of directories it looks in should help. I think if /usr or /usr/X11 has a version of freetype that's incompatible with /usr/bin/python, it's an Apple bug, but people could have installed whatever libraries in /usr/local (perhaps indirectly - .pkg installers can leave stuff all over your system). Does the output from "python setup.py build" indicate which directories each dependency is found in? That information could help when people report build problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pelson

pelson commented Jun 29, 2012

Copy link
Copy Markdown
Member

Does the output from "python setup.py build" indicate which directories each dependency is found in?

No. But it looks like the setupext could be made to do so with a bit of effort if we did want that ability. I'm going to merge this issue, but will open a subsequent issue for getting the path info for some of the build dependencies.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pelson added a commit that referenced this pull request Jun 29, 2012
@pelson
Merge pull request #965 from r-owen/master
a720fd7
Updated setupext.py that allows building on Mac OS X
@pelson
pelson merged commit a720fd7 into matplotlib:master Jun 29, 2012
@pelson pelson mentioned this pull request Jun 30, 2012
Fixing library path in setupext.py for Mac #213
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@r-owen @pelson @jswhit @efiring @jkseppan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.