Description

rgdoliveira

opened on Jul 13, 2017

Issue body actions

I'm compiling zstd in a Powerpc machine (ppc64le) and it builds fine, but when I try to run the test suite it fails with the following error:
"zstd: error 30 : allocation error : can't create ZSTDMT_CCtx"

zstd defines the max number of cores as 128 (ZSTDMT_NBTHREADS_MAX 128) but the Power machine I'm using has 160 cores and the test break.

In this case I guess the execution should continue and use the max number of cores instead of breaking it.

Activity

1. rgdoliveira

   added 2 commits that reference this issue on Jul 13, 2017

   community/zstd: fix tests in ppc64le

   a3d5bba

   community/zstd: fix tests in ppc64le

   eee0dfb
2. Cyan4973 commented on Jul 13, 2017

   

   Cyan4973

   on Jul 13, 2017

   Contributor

   More actions

   That's a good point @rgdoliveira !
3. Cyan4973

   added a commit that references this issue on Jul 13, 2017

   policy change : ZSTDMT automatically caps nbThreads to ZSTDMT_NBTHREA…

   3a60efd
4. Cyan4973 commented on Jul 13, 2017

   

   Cyan4973

   on Jul 13, 2017

   Contributor

   More actions

   I modified the version in dev branch to accept up to 256 threads.
   It will also automatically cap to this new limit when requested more than this value, instead of triggering an error as you experienced.

   Reacted by Natanael Copa
5. algitbot

   added a commit that references this issue on Jul 13, 2017

   community/zstd: fix tests in ppc64le

   f9f234d
6. Cyan4973

   added a commit that references this issue on Jul 13, 2017

   updated NEWS regarding #760

   6733c07
7. rgdoliveira commented on Jul 19, 2017

   

   rgdoliveira

   on Jul 19, 2017

   Author

   More actions

   thanks @Cyan4973, As this issue is fixed in dev branch and I guess it will be part of a future zstd release, I'm closing this issue.

   Reacted by Yann Collet and George Liu (eva2000)
8. rgdoliveira

   closed this as completedon Jul 19, 2017

Issue actions