GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add isGlobalCompletion to CompletionInfo for snippet injection by jramsay · Pull Request #11338 · microsoft/TypeScript

Conversation

@jramsay

@jramsay jram (jramsay) commented Oct 4, 2016

Copy link
Copy Markdown
Member

// cc: Mohamed Hegazy (@mhegazy), Vladimir Matveev (@vladima) , Bill Ticehurst (@billti) , Arthur Ozga (@aozgaa)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jramsay
Add isGlobalCompletion to CompletionInfo for snippet injection
d186c83
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Oct 4, 2016
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Oct 4, 2016
View reviewed changes

@mhegazy Mohamed Hegazy (mhegazy) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments. 👍 otherwise.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/services/completions.ts Outdated
}

const semanticStart = timestamp();
let isGlobalCompletion: boolean;

@mhegazy Mohamed Hegazy (mhegazy) Oct 4, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would set this to false here, and only to true in the else branch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jramsay jram (jramsay) Oct 4, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good - done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/cases/fourslash/completionListIsGlobalCompletion.ts Outdated
goTo.marker("1");
verify.completionListIsGlobal(false);
goTo.marker("2");
verify.completionListIsGlobal(undefined);

@mhegazy Mohamed Hegazy (mhegazy) Oct 4, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make these true/false only and skip undefined

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jramsay jram (jramsay) Oct 4, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jramsay
Changes from CR feedback
62fddba
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Oct 4, 2016
View reviewed changes
@jramsay
jram (jramsay) merged commit f4dc114 into master Oct 4, 2016
@mhegazy
Mohamed Hegazy (mhegazy) deleted the AddIsGlobalCompletionForSnippets branch November 2, 2017 21:05
@sheetalkamat Sheetal Nandi (sheetalkamat) mentioned this pull request Jan 22, 2018
Fix bug: Support this. completions even when isGlobalCompletion is false #21330
Merged
@ghost ghost mentioned this pull request Jan 22, 2018
Remove isGlobalCompletionScope #21342
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jramsay @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.