GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — wrap subexpressions of conditional expressions in parens if necessary by vladima · Pull Request #12420 · microsoft/TypeScript

Conversation

@vladima

@vladima Vladimir Matveev (vladima) commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

fixes #12413

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vladima
wrap subexpressions of conditional expressions in parens if necessary
99312c0
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Nov 21, 2016
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Nov 21, 2016
View reviewed changes
@vladima
Vladimir Matveev (vladima) merged commit 4c6b94f into master Nov 21, 2016
@vladima
Vladimir Matveev (vladima) deleted the vladima/12413 branch November 21, 2016 20:52
Vladimir Matveev (vladima) added a commit that referenced this pull request Nov 21, 2016
@vladima
wrap subexpressions of conditional expressions in parens if necessary (…
9c6b2a3 
…#12420)
Vladimir Matveev (vladima) added a commit that referenced this pull request Nov 21, 2016
@vladima
wrap subexpressions of conditional expressions in parens if necessary (…
6389a0d 
…#12420) (#12422)
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2.1 compile error: "Unexpected token ," for ternary operator.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vladima @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.