GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Port master into release-2.6 10/19 by mhegazy · Pull Request #19348 · microsoft/TypeScript

Conversation

@mhegazy

@mhegazy Mohamed Hegazy (mhegazy) commented Oct 19, 2017

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Sheetal Nandi (sheetalkamat) and others added 30 commits October 12, 2017 11:50
@sheetalkamat
Adding test case where opened file included in project is not added t…
412e31b
…o ref count of configured project
@sheetalkamat
Fix the way configured project's reference is managed so that the ope…
b68a636
…n file
@sheetalkamat
Do not watch root folders for failed lookup locations and effective t…
50628e7
…ype roots

Fixes #19170
@csigs
LEGO: check in for master to temporary branch.
92d1919
@csigs
LEGO: Merge pull request 19241
fcb48dd
LEGO: Merge pull request 19241
@csigs
LEGO: check in for master to temporary branch.
1af25ae
@csigs
LEGO: Merge pull request 19248
3a84b66
LEGO: Merge pull request 19248
@sandersn
Mark fresh spread objects w/ContainsObjectLiteral
08d7e18
@sandersn
Test excess property checks of spreads of unions.
e58aa10
Andy
Add exported members of all project files in the global completion li…
2b566b9
…st (#19069)

* checker.ts: Remove null check on symbols

* tsserverProjectSystem.ts: add two tests

* client.ts, completions.ts, types.ts: Add codeActions member to CompletionEntryDetails

* protocol.ts, session.ts: Add codeActions member to CompletionEntryDetails protocol

* protocol.ts, session.ts, types.ts: add hasAction to CompletionEntry

* session.ts, services.ts, types.ts: Add formattingOptions parameter to getCompletionEntryDetails

* completions.ts: define SymbolOriginInfo type

* completions.ts, services.ts: Add allSourceFiles parameter to getCompletionsAtPosition

* completions.ts, services.ts: Plumb allSourceFiles into new function getSymbolsFromOtherSourceFileExports inside getCompletionData

* completions.ts: add symbolToOriginInfoMap parameter to getCompletionEntriesFromSymbols and to return value of getCompletionData

* utilities.ts: Add getOtherModuleSymbols, getUniqueSymbolIdAsString, getUniqueSymbolId

* completions.ts: Set CompletionEntry.hasAction when symbol is found in symbolToOriginInfoMap (meaning there's an import action)

* completions.ts: Populate list with possible exports (implement getSymbolsFromOtherSourceFileExports)

* completions.ts, services.ts: Plumb host and rulesProvider into getCompletionEntryDetails

* completions.ts: Add TODO comment

* importFixes.ts: Add types ImportDeclarationMap and ImportCodeFixContext

* Move getImportDeclarations into getCodeActionForImport, immediately after the implementation

* importFixes.ts: Move createChangeTracker into getCodeActionForImport, immediately after getImportDeclarations

* importFixes.ts: Add convertToImportCodeFixContext function and reference it from the getCodeActions lambda

* importFixes.ts: Add context: ImportCodeFixContext parameter to getCodeActionForImport, update call sites, destructure it, use compilerOptions in getModuleSpecifierForNewImport

* importFixes.ts: Remove moduleSymbol parameter from getImportDeclarations and use the ambient one

* importFixes.ts: Use cachedImportDeclarations from context in getCodeActionForImport

* importFixes.ts: Move createCodeAction out, immediately above convertToImportCodeFixContext

* Move the declaration for lastImportDeclaration out of the getCodeActions lambda into getCodeActionForImport

* importFixes.ts: Use symbolToken in getCodeActionForImport

* importFixes.ts: Remove useCaseSensitiveFileNames altogether from getCodeActions lambda

* importFixes.ts: Remove local getUniqueSymbolId function and add checker parameter to calls to it

* importFixes.ts: Move getCodeActionForImport out into an export, immediately below convertToImportCodeFixContext

* completions.ts: In getCompletionEntryDetails, if there's symbolOriginInfo, call getCodeActionForImport

* importFixes.ts: Create and use importFixContext within getCodeActions lambda

* importFixes.ts: Use local newLineCharacter instead of context.newLineCharacter in getCodeActionForImport

* importFixes.ts: Use local host instead of context.host in getCodeActionForImport

* importFixes.ts: Remove dummy getCanonicalFileName line

* Filter symbols after gathering exports instead of before

* Lint

* Test, fix bugs, refactor

* Suggestions from code review

* Update api baseline

* Fix bug if previousToken is not an Identifier

* Replace `startsWith` with `stringContainsCharactersInOrder`
@weswigham
Dont try to run unit tests with rwc tests again (#19240)
f09fe3d
@sandersn
Merge pull request #19250 from Microsoft/mark-fresh-spread-types-with…
487504d
…-ContainsObjectLiteral

Mark fresh spread types with ContainsObjectLiteral
Andy
In tsserver, indent logged JSON (#19080)
d0c4d13
Andy
noUnusedLocals: Warn for recursive call to private method (#18920)
28509e1
@sheetalkamat
Added test for windows style paths watched directories
49cfbb4
@sheetalkamat
Merge pull request #19239 from Microsoft/reduceWatchedDirectories
314172a
Do not watch root folders for failed lookup locations and effective type roots
@sheetalkamat
Handle when directory watcher is invoked on file change
a5861af
Fixes #19206
@sheetalkamat
Merge branch 'master' into directoryWatcherInsteadOfFileWatch
bd0c210
Andy
Add quickfix and refactoring to install @types packages (#19130)
d05443b
* Add quickfix and refactoring to install @types packages

* Move `validatePackageName` to `jsTyping.ts`

* Remove combinePaths overloads

* Respond to code review

* Update api baselines

* Use native PromiseConstructor

* Return false instead of undefined

* Remove getProjectRootPath

* Update api
@sheetalkamat
Merge pull request #19263 from Microsoft/directoryWatcherInsteadOfFil…
e99e933
…eWatch

This fixes the issue with tsc --watch when module emit kind is none and directory watcher gets invoked instead of file
@weswigham
This wasnt required before... (#19262)
2cc4f53
@sandersn
Collapse jsdoc annotation refactors to one
64fc495
Previously there were two, and two always fired.
@sandersn
Update baselines
e962e4a
@mhegazy
Fix #19257: Ensure a generated signature has a return type (#19264)
0c1730a
* Fix #19257: Ensure a generated signature has a return type

* Ensure generated properties have types

* Use the same context for multiple inferences to the same property access
@weswigham
Respect newLine compiler option in language service output (#19279)
f9df4e6
@csigs
LEGO: check in for master to temporary branch.
b792daa
@csigs
LEGO: Merge pull request 19281
574ebf7
LEGO: Merge pull request 19281
@csigs
LEGO: check in for master to temporary branch.
d08b58c
@csigs
LEGO: Merge pull request 19288
d01df02
LEGO: Merge pull request 19288
@csigs
LEGO: check in for master to temporary branch.
2ca0df8
Sheetal Nandi (sheetalkamat) and others added 27 commits October 18, 2017 13:34
@sheetalkamat
Use get files affected by internally and hence use file paths as input
f9c901a
@sheetalkamat
Modify api to emit affected files using callback instead of generatin…
8fbfb5f
…g in memory output

Also marking few apis introduced during watch improvements changes that are suppose to be internal for now
@sheetalkamat
Simplify emit changed files further
835d7cb
Also use source file version as the signature of declaration file instead of computing it from text
@sheetalkamat
Do not cache the semantic diagnostics when compiler options has --out…
7e780c0
… since we would anyways get all fresh diagnostics
@sheetalkamat
Merge pull request #19138 from Microsoft/configuredProjectRef
f592419
Handle the configured project lifetime to account for files added to the project after config file gets reloaded
@sandersn
Merge pull request #19304 from Microsoft/dedupe-jsdoc-annotation-refa…
b40e18d
…ctors

Fixes for refactor "Annotate with type from JSDoc"
@weswigham
make getCurrentDirectory required (#19303)
75a687b
@csigs
LEGO: check in for master to temporary branch.
7d23ed1
@csigs
LEGO: Merge pull request 19312
7bfda06
LEGO: Merge pull request 19312
@sheetalkamat
Actually use cached semantic diagnostics
9bea0db
@sandersn
Fix tsc-instrumented
93c2b10
1. Make recursiveCreateDirectory correctly handle relative paths.
2. Remove dependency on Harness
3. Correctly increment iocapture0, iocapture1, ... iocaptureN.
4. Stop double-nesting baseline files.
@sandersn
Fix lint
79c6724
@mhegazy
Fix #19270: ensure output name is a valid locale name (#19308)
5fa8db5
* Fix #19270: ensure output name is a valid locale name

* Use const instead of var

* Add comment

* Fix typo

* Split the concat logic for generatedLCGFile
Andy @mhegazy
findAllRefs: Support anonymous default export (#19302)
e5f8287
Andy @mhegazy
Fix undefined error using getEffectiveTypeRoots (#19300)
f1abe3c
Andy
Remove extra blank line in logs (#19307)
6c1afba
Andy
Use Promise instead of PromiseLike (#19305)
0f55f4a
@sheetalkamat
Merge pull request #19306 from Microsoft/doNoWriteFilesMultipleTimes
8fc6518
Fixes the issue with emit where in same file is emitted multiple times
@sandersn
Merge pull request #19314 from Microsoft/fix-tsc-instrumented
d8373c3
Fix four tsc-instrumented bugs
@weswigham
Workaround for nonnull operator on indexed accesses (#19275)
8212c96
* Quick and dirty workaround

* Add third case to show current behavior

* Rename variable, replace elaboration from comment with links
Andy
Remove some unnecessary undefined checks in extractSymbol (#19256)
a53d3bb
Andy
Fix "noStringLiteral" lint errors (#19310)
1f282f1
@csigs
LEGO: check in for master to temporary branch.
5a6e5e7
@csigs
LEGO: Merge pull request 19342
8695f38
LEGO: Merge pull request 19342
@mhegazy
Merge branch 'master' into release-2.6
24a92a6
@mhegazy
Rename locale outputs
f89603b
@mhegazy
Update LKG
491191c
@mhegazy
Mohamed Hegazy (mhegazy) merged commit 8475e30 into release-2.6 Oct 19, 2017
@mhegazy
Mohamed Hegazy (mhegazy) deleted the port-master-10-19 branch October 19, 2017 20:14
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@mhegazy @sheetalkamat @csigs @sandersn @weswigham @billti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.